overcloud deploy fails when using puppet-ceph-external.yaml

[Graeme Seaton]

When deploying the overcloud on newton it fails when using the provided puppet-ceph-external (altered only with FSID etc.) with:

 u'message': u'Failed to run action [action_ex_id=7dc5b21d-10c4-48bd-a4e2-c3cb0bad2dbe, action_cls=\'<class \'mistral.actions.action_factory.DeployStackAction\'>\', attributes=\'{}\', params=\'{u\'container\': u\'overcloud\', u\'timeout\': 60}\']\n ERROR: Failed to validate: : resources.ComputeServiceChain: : Failed to validate nested template: Failed to validate: resources[2]: Validation error in output "role_data": The specified reference "CephBase" (in unknown) is incorrect.',
 u'status': u'FAILED'}

By comparing the files in /usr/share/openstack-tripleo-heat-templates/puppet/services it appears that ceph-external.yaml is missing the following resource definition:

resources:
  CephBase:
    type: ./ceph-base.yaml
    properties:
      ServiceNetMap: {get_param: ServiceNetMap}
      DefaultPasswords: {get_param: DefaultPasswords}
      EndpointMap: {get_param: EndpointMap}

[Attila Fazekas (afazekas)]

I run into the same issue yesterday, I used my usual settings (same env as 1 month before),
The environments/puppet-ceph-external.yaml example was not changed for month, so I expect it is something unexpected consequence(bug).

[Giulio Fidente (gfidente)]

I think it's just an incorrect reference to CephBase in service_config_settings, working on it

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/392558

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394993

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/392558
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ba66980aa3d1fd981363173803e926642dc66227
Submitter: Jenkins
Branch: master

commit ba66980aa3d1fd981363173803e926642dc66227
Author: Giulio Fidente <email address hidden>
Date: Wed Nov 2 12:13:18 2016 +0100

    Do not reference CephBase from CephExternal service

    We want CephExternal to work without referencing CephBase which
    instead defines common settings for hosted Ceph deployments.

    This change fixes a reference to CephBase which was mistakenly
    introduced with fix for bug #1632285.

    Change-Id: Id27e935f91ad76a6877b3aa7588f54d6140aa41f
    Closes-Bug: #1635014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394993
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d3b71155ecbfaa6ba33a3bda2999016a69a04629
Submitter: Jenkins
Branch: stable/newton

commit d3b71155ecbfaa6ba33a3bda2999016a69a04629
Author: Giulio Fidente <email address hidden>
Date: Wed Nov 2 12:13:18 2016 +0100

    Do not reference CephBase from CephExternal service

    We want CephExternal to work without referencing CephBase which
    instead defines common settings for hosted Ceph deployments.

    This change fixes a reference to CephBase which was mistakenly
    introduced with fix for bug #1632285.

    Change-Id: Id27e935f91ad76a6877b3aa7588f54d6140aa41f
    Closes-Bug: #1635014
    (cherry picked from commit ba66980aa3d1fd981363173803e926642dc66227)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.1.0 release.