puppet-ntp is breaking ci

[Michele Baldessari]

ntp puppetlab module (https://github.com/puppetlabs/puppetlabs-ntp) has removed puppet 3 compatbility. This seems to be breaking CI:
http://logs.openstack.org/21/386921/2/check-tripleo/gate-tripleo-ci-centos-7-ovb-ha/04d2b18/logs/postci.txt.gz
http://logs.openstack.org/21/386921/2/check/gate-tripleo-ci-centos-7-nonha-multinode-updates-nv/11c6694/logs/postci.txt.gz

The error is:

2016-10-15 10:59:46.000 | Error: Syntax error at 'Any'; expected ')' at /etc/puppet/modules/ntp/manifests/init.pp:2 on node centos-7-2-node-osic-cloud1-s3500-4938754-236280.localdomain
2016-10-15 10:59:46.000 | Error: Syntax error at 'Any'; expected ')' at /etc/puppet/modules/ntp/manifests/init.pp:2 on node centos-7-2-node-osic-cloud1-s3500-4938754-236280.localdomain

[Emilien Macchi (emilienm)]

Will be fixed by https://review.openstack.org/#/c/371209/

[Emilien Macchi (emilienm)]

In fact, we need to fix it in packaging: https://review.rdoproject.org/r/#/c/3345/1

[Emilien Macchi (emilienm)]

Pinned in RDO.

[Ana Krivokapić (akrivoka)]

I'm still hitting this issue. I have puppet-ntp-4.2.0-0.20161017093645.93da3bd.el7.centos.noarch installed on my undercloud.

[stack@instack ~]$ openstack stack failures list overcloud
overcloud.AllNodesDeploySteps.ComputeDeployment_Step1.0:
  resource_type: OS::Heat::StructuredDeployment
  physical_resource_id: 5aff3f38-1f09-47ec-a383-ed3a8e5a5012
  status: CREATE_FAILED
  status_reason: |
    Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1
  deploy_stdout: |
    Matching apachectl 'Server version: Apache/2.4.6 (CentOS)
    Server built: Jul 18 2016 15:30:14'
  deploy_stderr: |
    exception: connect failed
    Error: Syntax error at 'Any'; expected ')' at /etc/puppet/modules/ntp/manifests/init.pp:2 on node overcloud-novacompute-0.localdomain
    Error: Syntax error at 'Any'; expected ')' at /etc/puppet/modules/ntp/manifests/init.pp:2 on node overcloud-novacompute-0.localdomain
overcloud.AllNodesDeploySteps.ControllerArtifactsDeploy:
  resource_type: OS::Heat::StructuredDeployments
  physical_resource_id: ea809341-bc5b-4e2b-b542-310d30ae2257
  status: CREATE_FAILED
  status_reason: |
    CREATE aborted

[Alan Pevec (apevec)]

Ana, what is the puppet-ntp module in the overcloud image and where did you get the image from?
RDO master trunk build puppet-ntp-4.2.0-0.20161017093645.93da3bd.el7 did pass CI and should be good, I suspect overcloud image has something else.

[Alex Schultz (alex-schultz)]

If you install the modules from source, you may be getting the master ntp module which is breaking things. I believe the way to pin a module for that is to export DIB_REPOREF_puppetlabs_ntp=4.2.x prior to building the overcloud images.

[Ana Krivokapić (akrivoka)]

After further investigation, we concluded that even though the correct version of the puppet-npm package is now being installed on the undercloud, the overcloud is still hitting this error if you use the puppet modules from source. There are two possible workarounds for this:

1) Use the pre-built images instead of building custom images
2) Build custom images, but don't use the puppet modules from source for this (don't set DIB_INSTALLTYPE_puppet_modules=source before building images)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/389250

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389250
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=59e5ff63c8e4f6ad128f454ff5eab5cccbda5566
Submitter: Jenkins
Branch: master

commit 59e5ff63c8e4f6ad128f454ff5eab5cccbda5566
Author: Alex Schultz <email address hidden>
Date: Thu Oct 20 09:30:34 2016 -0600

    Pin puppetlabs-ntp when installing from source

    Due to the puppet3 support removal in the upstream puppetlabs-ntp
    module, we need to provide a default pin for the module when a developer
    is installing from source. If the user does not properly pin the ntp
    module, the overcloud deployment fails due to a puppet parse error.

    Change-Id: I2f4c1387b61c4aa2dcbb1ec5a3fa298e9330f0e8
    Closes-Bug: #1633713

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 6.0.0.0b1 development milestone.