ObjectStorage role broken due to missing ManagementPort

Bug #1632663 reported by Steven Hardy on 2016-10-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Steven Hardy

Bug Description

We don't test the ObjectStorage role in CI, hence missed that there's a mismatch where we generate the per-role environment file contents for default network ports, but there's a mismatch:

OS::TripleO::SwiftStorage::Ports::ManagementPort

SwiftStorage isn't the name of the role, so this breaks.

Fix proposed to branch: master
Review: https://review.openstack.org/385392

Changed in tripleo:
assignee: nobody → Steven Hardy (shardy)
status: New → In Progress
Steven Hardy (shardy) on 2016-10-12
Changed in tripleo:
milestone: none → ocata-1
importance: Undecided → High
tags: added: newton-backport-potential

Reviewed: https://review.openstack.org/385392
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=29306b7ec0ead728db16b24defd493bcff0e544f
Submitter: Jenkins
Branch: master

commit 29306b7ec0ead728db16b24defd493bcff0e544f
Author: Steven Hardy <email address hidden>
Date: Wed Oct 12 11:50:23 2016 +0100

    Special case non-matching ObjectStorage role port names

    Unfortunately we use "SwiftStorage" in the ObjectStorage role
    template, so we have to special-case this for backwards compatibility
    or deployments enabling the ObjectStorage role will fail.

    Ideally we'd align the port names in the objectstorage-role.yaml, but we
    can't becauuse all the ports would be replaced in existing deployments
    on update.

    Change-Id: Ia07e193d2b9a4d33c6272c2b4448133584b81350
    Closes-Bug: #1632663

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/386191
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=754fc4e948263266e57c31ca2a40fde4cbb67a2f
Submitter: Jenkins
Branch: stable/newton

commit 754fc4e948263266e57c31ca2a40fde4cbb67a2f
Author: Steven Hardy <email address hidden>
Date: Wed Oct 12 11:50:23 2016 +0100

    Special case non-matching ObjectStorage role port names

    Unfortunately we use "SwiftStorage" in the ObjectStorage role
    template, so we have to special-case this for backwards compatibility
    or deployments enabling the ObjectStorage role will fail.

    Ideally we'd align the port names in the objectstorage-role.yaml, but we
    can't becauuse all the ports would be replaced in existing deployments
    on update.

    Change-Id: Ia07e193d2b9a4d33c6272c2b4448133584b81350
    Closes-Bug: #1632663
    (cherry picked from commit 29306b7ec0ead728db16b24defd493bcff0e544f)

tags: added: in-stable-newton

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0rc3 release candidate.

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0 release.

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers