openstack overcloud profiles match shows deprecates args

Bug #1629907 reported by Dougal Matthews on 2016-10-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Ana Krivokapić

Bug Description

the --*-flavor and --*-scale CLI args were deprecated for the deploy command. This had the unintentional side effect of making them as deprecated in the "openstack overcloud profiles match" command despite there being no alternative method.

 > [stack@instack ~]$ openstack overcloud profiles match --help
 > WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils
 > usage: openstack overcloud profiles match [-h] [--dry-run]
 > [--control-scale CONTROL_SCALE]
 > [--compute-scale COMPUTE_SCALE]
 > [--ceph-storage-scale CEPH_STORAGE_SCALE]
 > [--block-storage-scale BLOCK_STORAGE_SCALE]
 > [--swift-storage-scale SWIFT_STORAGE_SCALE]
 > [--control-flavor CONTROL_FLAVOR]
 > [--compute-flavor COMPUTE_FLAVOR]
 > [--ceph-storage-flavor CEPH_STORAGE_FLAVOR]
 > [--block-storage-flavor BLOCK_STORAGE_FLAVOR]
 > [--swift-storage-flavor SWIFT_STORAGE_FLAVOR]
 >
 > Assign and validate profiles on nodes
 >
 > optional arguments:
 > -h, --help show this help message and exit
 > --dry-run Only run validations, but do not apply any changes.
 > --control-scale CONTROL_SCALE
 > New number of control nodes. (DEPRECATED. Use an
 > environment file and set the parameter
 > ControllerCount. It will be removed after the "P"
 > release.)
 > --compute-scale COMPUTE_SCALE
 > New number of compute nodes. (DEPRECATED. Use an
 > environment file and set the parameter ComputeCount.
 > It will be removed after the "P" release.)
 > --ceph-storage-scale CEPH_STORAGE_SCALE
 > New number of ceph storage nodes. (DEPRECATED. Use an
 > environment file and set the parameter
 > CephStorageCount. It will be removed after the the "P"
 > release.)
 > --block-storage-scale BLOCK_STORAGE_SCALE
 > New number of cinder storage nodes. (DEPRECATED. Use
 > an environment file and set the parameter
 > BlockStorageCount. It will be removed after the "P"
 > release.)
 > --swift-storage-scale SWIFT_STORAGE_SCALE
 > New number of swift storage nodes. (DEPRECATED. Use an
 > environment file and set the parameter
 > ObjectStorageCount. It will be removed after the "P"
 > release.)
 > --control-flavor CONTROL_FLAVOR
 > Nova flavor to use for control nodes. (DEPRECATED. Use
 > an environment file and set the parameter
 > OvercloudControlFlavor. It will be removed after the
 > "P" release.)
 > --compute-flavor COMPUTE_FLAVOR
 > Nova flavor to use for compute nodes. (DEPRECATED. Use
 > an environment file and set the parameter
 > OvercloudComputeFlavor. It will be removed after the
 > "P" release.)
 > --ceph-storage-flavor CEPH_STORAGE_FLAVOR
 > Nova flavor to use for ceph storage nodes.
 > (DEPRECATED. Use an environment file and set the
 > parameter OvercloudCephStorageFlavor. It will be
 > removed after the "P" release.)
 > --block-storage-flavor BLOCK_STORAGE_FLAVOR
 > Nova flavor to use for cinder storage nodes.
 > (DEPRECATED. Use an environment file and set the
 > parameter OvercloudBlockStorageFlavor. It will be
 > removed after the "P" release.)
 > --swift-storage-flavor SWIFT_STORAGE_FLAVOR
 > Nova flavor to use for swift storage nodes.
 > (DEPRECATED. Use an environment file and set the
 > parameter OvercloudSwiftStorageFlavor. It will be
 > removed after the "P" release.)

Changed in tripleo:
status: Confirmed → Triaged
Emilien Macchi (emilienm) wrote :

Moving it to Ocata 1. It doesn't seem critical for RC3.

Changed in tripleo:
milestone: newton-rc3 → ocata-1

Fix proposed to branch: master
Review: https://review.openstack.org/392166

Changed in tripleo:
assignee: nobody → Ana Krivokapić (akrivoka)
status: Triaged → In Progress
Steven Hardy (shardy) on 2016-11-16
Changed in tripleo:
milestone: ocata-1 → ocata-2

Reviewed: https://review.openstack.org/392166
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=d7309d5317410905b0e8244c24e2095767fae693
Submitter: Jenkins
Branch: master

commit d7309d5317410905b0e8244c24e2095767fae693
Author: Ana Krivokapic <email address hidden>
Date: Tue Nov 1 14:35:10 2016 +0100

    Only show deprecated args for overcloud deploy

    The --*-flavor and --*-scale CLI args were deprecated for the "openstack
    overcloud deploy" command. This had the unintentional side effect of making
    them as deprecated in the "openstack overcloud profiles match" command despite
    there being no alternative method.

    This change amends that so that the deprecation warnings are only shown for the
    "deploy" command.

    Change-Id: Iaf60e1e9c99f50d6e63b7da1712a728cd89559a4
    Closes-bug: #1629907

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-tripleoclient 5.6.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers