tripleo::profile::base::ceilometer::collector should use normalize_ip_for_uri for ipv6 address handling

Bug #1629380 reported by Alex Schultz on 2016-09-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Low
Alex Schultz

Bug Description

https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/ceilometer/collector.pp#L46-L53

The ipv6 address bracketing can be handled by the normailze_ip_for_uri function provided by puppet-openstacklib. We should switch to that and stop relying on the mongodb::server::ipv6 hiera value.

See https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/swift/proxy.pp#L40 as an example

Changed in tripleo:
milestone: none → ocata-1
Steven Hardy (shardy) on 2016-11-11
Changed in tripleo:
milestone: ocata-1 → ocata-2

Fix proposed to branch: master
Review: https://review.openstack.org/400905

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
status: Triaged → In Progress

Reviewed: https://review.openstack.org/400905
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=960ba650670794f0309b1f2e8c4d3707c9ca32e5
Submitter: Jenkins
Branch: master

commit 960ba650670794f0309b1f2e8c4d3707c9ca32e5
Author: Alex Schultz <email address hidden>
Date: Tue Nov 22 10:50:29 2016 -0700

    Update ceilometer collector ipv6 handling

    The normalize_ip_for_uri handles ipv6 bracketing correctly. Rather
    than continue to do it manually, this change updates the ceilometer
    collector profile to leverage the normalize_ip_for_uri function to
    properly escape ipv6 addresses.

    Change-Id: Ifaf6568785235db55f8dc593d83e534216413d31
    Closes-Bug: #1629380

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/puppet-tripleo 6.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers