CI not testing changes made in submitted patches

Bug #1623891 reported by Jiří Stránský
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Jiří Stránský

Bug Description

CI doesn't test changes made (here's a no-merge patch to test/prove that https://review.openstack.org/#/c/370647/).

We run --delorean-build twice in the CI:

https://github.com/openstack-infra/tripleo-ci/blob/4e6154027133f20dce4d300fc6701848000e9c3b/scripts/common_functions.sh#L266-L273

The 2nd run apparently clears out what the first run built, so we're only ever installing that diskimage-builder patch, but not the one we actually want to test.

Tags: ci
Changed in tripleo:
importance: Undecided → Critical
Revision history for this message
Jiří Stránský (jistr) wrote :

Slagle has a patch to fix it here https://review.openstack.org/#/c/370281/

Revision history for this message
Jiří Stránský (jistr) wrote :

Erm sorry, it was Ben's patch ^^

Anyway i don't want to edit it in place if i'm not sure whether i'm going closer or further from the fixed state, so submitted another one to experiment:

https://review.openstack.org/#/c/370724/

Revision history for this message
Emilien Macchi (emilienm) wrote :

For the record, I already did that patch 2 days ago: https://review.openstack.org/#/c/369792/

Changed in tripleo:
status: Triaged → Fix Released
tags: removed: alert
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.