Deploy parameters ashould be set in the mistral workflow

Bug #1621099 reported by Dougal Matthews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jeff Peeler

Bug Description

The parameters DeployIdentifier, UpdateIdentifier and StackAction were set by the CLI. This logic should be moved to the deploy mistral workflow.

A work in progress patch has been started here: https://review.openstack.org/#/c/365625/

Revision history for this message
Dougal Matthews (d0ugal) wrote :

The goal of this is to replace this logic in the CLI. So the GUI (and others) don't need to manually do these steps.

https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_deploy.py#L126-L129

Jeff Peeler (jpeeler-z)
Changed in tripleo:
assignee: nobody → Jeff Peeler (jpeeler-z)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/365625
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=65d0fb68e287d2b5b444889d55c277573515e9a3
Submitter: Jenkins
Branch: master

commit 65d0fb68e287d2b5b444889d55c277573515e9a3
Author: Jeff Peeler <email address hidden>
Date: Thu Sep 8 16:57:39 2016 -0400

    Set Deployment Parameters

    Previously in python-tripleoclient, they tried to use UpdateIdentifier
    or two different things: tell whether to perform package update, and
    also to tell whether the top-level stack is being created or updated
    (which was incorrect and resulted in bug 1567384, and an attempt to
    work around that bug resulted in bug 1567385).

    Heat's "action" conditionals cannot be used in some cases, because they
    refer to the direct parent stack, which can yield undesirable results
    when introducing new nested stacks or temporarily no-opping something
    and then adding it back (in both these cases, "action" would be
    considered "CREATE", even though the top-level stack is in "UPDATE").

    UpdateIdentifier is cleared on deploy/scale to make sure that package
    update doesn't get triggered, and we pass the StackAction parameter to
    allow us to correctly distinguish between create vs. update of the
    top-level stack, and condition the pacemaker restarts on this variable
    instead.

    This patch sets the parameters mentioned above and stores them in a
    Mistral Environment. These parameters are retrieved during the
    ProcessTemplatesAction and subsequently merged into the Heat
    environment.

    Co-Authored-By: Dougal Matthews <email address hidden>
    Co-Authored-By: Jeff Peeler <email address hidden>
    Closes-Bug: #1621099
    Change-Id: I88b6c1c60b2cc5de8bcf67348458c8de025779da

Changed in tripleo:
status: Confirmed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Ryan Brady (<email address hidden>) on branch: master
Review: https://review.openstack.org/370383
Reason: This didn't get enough traction before. I'll try to revisit it later in Ocata

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.