os-collect-config ec2 collector should attempt config-drive before nova metadata server

[Steve Baker]

overcloud nodes are booted with a functioning config-drive, and cloud-init uses this for boot configuration.

However the os-collect-config ec2 collector fetches the same data from the nova metadata server. If the ec2 collector is treated as immutable as per bug 1619072 then config-drive can be used as the data source instead of the nova metadata server.

This can result in a significant reduction in complexity - the openstack-nova-api service can be switched off on the undercloud and routing to 169.254.169.254 removed.

[Steven Hardy (shardy)]

Sounds reasonable, although I'd like to check the impact of disabling the metadata server - AFAIK there are actually two sets of metadata served via the magic metadata IP, the ec2 stuff and the native key/value pairs, the latter we may want to keep because we expose the sever metadata property in t-h-t (and it can be updated).

Regardless, the occ optimization seems worthwhile

[Steven Hardy (shardy)]

https://review.openstack.org/#/c/369731/ is WIP so deferring this to ocata-1

[Steven Hardy (shardy)]

https://review.openstack.org/#/c/369731/ is ready for review, but not yet landed, so moving this to ocata-2

[Steve Baker (steve-stevebaker)]

https://review.openstack.org/#/c/369731/ merged 3 weeks ago, this should probably be in ocata-2

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-collect-config 6.0.0.0b2 development milestone.