Remove the print statements from tripleoclient and replace with log.(debug|info|warning)

Bug #1617199 reported by Dougal Matthews
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
Invalid
Wishlist
Natal Ngétal

Bug Description

The output from tripleoclient isn't consistent in the level of detail that it exposes. It would be better to look at each use of the print statement and use the relevant log output in it's place.

The wording and terminology also needs to be checked in the process to make sure we are displaying enough information and only relevant information.

Sai Kiran (saikiran)
Changed in tripleo:
assignee: nobody → Sai Kiran (saikiran)
Sai Kiran (saikiran)
Changed in tripleo:
status: Confirmed → In Progress
Dougal Matthews (d0ugal)
tags: added: low-hanging-fruit
Revision history for this message
Emilien Macchi (emilienm) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in tripleo:
status: In Progress → Confirmed
assignee: Sai Kiran (saikiran) → nobody
Changed in tripleo:
assignee: nobody → Md Nadeem (mail2nadeem92)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/504848

Changed in tripleo:
status: Confirmed → In Progress
Revision history for this message
David Peacock (davidjpeacock) wrote :

Is this bug still relevant? I other work has been done in this area (partially by myself, partially by bodango). I see the posted review is very old and looks abandoned.

Can we close out this bug?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/504848
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines (https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html). If you wish to have this restored and cannot do so yourself, please reach out via #tripleo on freenode or the OpenStack Dev mailing list.

Changed in tripleo:
milestone: none → stein-3
assignee: Md Nadeem (mail2nadeem92) → nobody
importance: Medium → Wishlist
status: In Progress → Triaged
Changed in tripleo:
assignee: nobody → Natal Ngétal (hobbestigrou)
status: Triaged → In Progress
Revision history for this message
Natal Ngétal (hobbestigrou) wrote :

A new patch is available here:

https://review.openstack.org/#/c/639344/

Please someone can check the patch? To have others advice also.

Changed in tripleo:
milestone: stein-3 → train-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Natal Ngétal (<email address hidden>) on branch: master
Review: https://review.openstack.org/639344
Reason: Actually, it's not the good way. In this context the print is better.

Revision history for this message
Natal Ngétal (hobbestigrou) wrote :

It's an old ticket. This a good idea in general, however in this context the print is better. Multiple patches was proposed and abandoned so I close the ticket.

Changed in tripleo:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.