Deploying with cinder-block-storage fails.

[Sofer Athlan-Guyot]

Using

    openstack overcloud deploy --templates --libvirt-type qemu \
          --control-flavor baremetal \
          --compute-flavor baremetal \
          --block-storage-flavor baremetal \
          --ceph-storage-flavor baremetal \
          --swift-storage-flavor baremetal \
          --control-scale 3 \
          --compute-scale 1 \
          --block-storage-scale 1 \
          --swift-storage-scale 1 \
          --ceph-storage-scale 1 \
          --neutron-network-type vxlan --neutron-tunnel-types vxlan \
          --ntp-server pool.ntp.org \
          --timeout 90 \
          -e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
          -e /usr/share/openstack-tripleo-heat-templates/environments/net-single-nic-with-vlans.yaml \
          -e $HOME/network-environment.yaml \
          -e /usr/share/openstack-tripleo-heat-templates/environments/storage-environment.yaml \
          -e /usr/share/openstack-tripleo-heat-templates/environments/config-debug.yaml \
          -e /home/stack/deploy_env.yaml

Fails very early with:

    12:41:18 2 nodes with profile None won't be used for deployment now
    12:41:18 Configuration has 1 warnings, fix them before proceeding.
    12:41:25 ERROR: Failed to validate: Failed to validate: resources[0]: The Parameter (Flavor) was not provided.

No other relevant message was included in the log.

Doing a pdb session on

    /usr/lib/python2.7/site-packages/heat/engine/stack.py +807

I could see the failing template:

    (Pdb) p res.template_name
    u'file:///usr/share/openstack-tripleo-heat-templates/puppet/cinder-storage.yaml'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/359844

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/359844
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5c1b9864e36ab259035e614bca6794a7c00b081c
Submitter: Jenkins
Branch: master

commit 5c1b9864e36ab259035e614bca6794a7c00b081c
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Aug 24 14:25:49 2016 +0200

    Fix Flavor get_param for Block Storage.

    The get_param of the flavor was not pointing to the right parameter,
    leading to an empty flavor for the block storage and a failure during
    validation.

    Change-Id: Id9a3d5756be956cedf060443533b84fcc66e721c
    Closes-Bug: 1616453

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0b3 development milestone.