Upgrades: mariadb dump/restore logic triggered when not necessary

Bug #1615721 reported by Jiří Stránský
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jiří Stránský

Bug Description

If we update from mariadb X.Y.Z to mariadb X.Y.Ž (sorry i need a letter that is after z, so ž is the first that comes to mind) then the major upgrade logic for mariadb is triggered. This involves a dump/restore of the databases, so we'd better avoid executing this if we can.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/358755

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: none → newton-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/358755
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=072404b5693439b728d49d26c2c11ed69172a40d
Submitter: Jenkins
Branch: master

commit 072404b5693439b728d49d26c2c11ed69172a40d
Author: Jiri Stransky <email address hidden>
Date: Mon Aug 22 18:23:35 2016 +0200

    Don't trigger mariadb upgrade dump/restore when not needed

    When upgrading from mariadb X.Y.Z to mariadb X.Y.Ž (X.Y part stays the
    same), the dump/restore of mariadb shouldn't be necessary. Therefore we
    now only check for up to the first 2 fields of the version string when
    determining if we should trigger the dump/restore operation.

    Closes-Bug: #1615721
    Change-Id: Ib7af8bfb121f5c83184d51b3c6dc657108c25973

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/359218

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/mitaka)

Reviewed: https://review.openstack.org/359218
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=690b94e2b60ee2d196a26a959126a36b13a237a3
Submitter: Jenkins
Branch: stable/mitaka

commit 690b94e2b60ee2d196a26a959126a36b13a237a3
Author: Jiri Stransky <email address hidden>
Date: Mon Aug 22 18:23:35 2016 +0200

    Don't trigger mariadb upgrade dump/restore when not needed

    When upgrading from mariadb X.Y.Z to mariadb X.Y.Ž (X.Y part stays the
    same), the dump/restore of mariadb shouldn't be necessary. Therefore we
    now only check for up to the first 2 fields of the version string when
    determining if we should trigger the dump/restore operation.

    Closes-Bug: #1615721
    Change-Id: Ib7af8bfb121f5c83184d51b3c6dc657108c25973
    (cherry picked from commit 072404b5693439b728d49d26c2c11ed69172a40d)

tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tripleo-heat-templates 2.1.0

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 5.0.0.0b3

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0b3 development milestone.

Revision history for this message
Marios Andreou (marios-b) wrote :

relevant bugzilla with some more discussion is at https://bugzilla.redhat.com/show_bug.cgi?id=1357112

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 2.1.0

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.