Servers get rebuilt during a stack update following new image rollout

[Zane Bitter]

The fix for the Heat bug 1514680 introduced a translation rule that means that the OS::Nova::Server resource now sees only the UUID of the image, even when the image is passed by name. This means that servers will be rebuilt on the next update after uploading new images.

TripleO always keeps the same name when uploading images with the expectation that this will not result in existing servers being rebuilt (however new servers will be created with the latest image).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/350145

[OpenStack Infra (hudson-openstack)]

Change abandoned by Zane Bitter (<email address hidden>) on branch: master
Review: https://review.openstack.org/350145
Reason: Ah yeah, I didn't notice that when the translation rule was added, the code to look up the UUID before creating the server was removed. That's much more difficult to surgically work around in a subclass :(

[Jiří Stránský (jistr)]

Here's a fix from Thomas which fell under the radar upstream and didn't get merged:

https://review.openstack.org/#/c/350778

Marius hit this problem when testing Newton, assigning the rc2 milestone, and also mitaka-backport-potential.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/350778
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=eaf00514412cbc5f369aed2477857e75c1a4a208
Submitter: Jenkins
Branch: master

commit eaf00514412cbc5f369aed2477857e75c1a4a208
Author: Thomas Herve <email address hidden>
Date: Wed Aug 3 22:35:43 2016 +0200

    Ignore changes to images in nova servers

    Override all changes to the image in OS::Nova::Server, so that we don't
    accidently rebuild them.

    Change-Id: I2ec318b9776239b166d9537e5ca10c851d1d219a
    Closes-Bug: #1609020

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.2.0 release.