loadbalancer.pp Not Properly Accepting Multiple Addresses

[Dan Sneddon]

This bug refers to two in-progress reviews which are not playing nice together.

This change in TripleO Heat Templates: https://review.openstack.org/#/c/289279/
is dependent on this change in puppet-tripleo: https://review.openstack.org/#/c/286344/

The THT change allows multiple addresses to be written to Hiera for the Public API endpoints. THT outputs an array, and puppet-tripleo is supposed to take that data, do a sanity check to ignore the Control Plane IP, and configure multiple endpoints in HAProxy. Somehow the output is getting concatenated from puppet-tripleo.

Steps to Reproduce:
1. Deploy with the dual-stack templates, like so:

THT=/home/stack/templates/tripleo-heat-templates
openstack overcloud deploy --templates $THT \
-e $THT/environments/network-isolation-v6-v4.yaml \
-e /home/stack/templates/network-environment-v6-v4.yaml \
--control-scale 1 \
--compute-scale 1 \
--neutron-network-type vxlan \
--neutron-tunnel-types vxlan \
--libvirt-type kvm \
--ntp-server 10.11.160.238 \
--timeout 180 \
--debug

Actual results:
Error:
'bind' : invalid address: '2001:db8:fd00:1000::1010.34.107.18' in '2001:db8:fd00:1000::1010.34.107.18:80'

Expected results:
Two IP addresses should be configured for the external VIP and the Keystone public VIP, one IPv6 and one IPv4.

Additional info:
Here are the contents of /etc/puppet/hieradata/vip_data.yaml:

aodh_api_vip: fd00:fd00:fd00:2000::14
ceilometer_api_vip: fd00:fd00:fd00:2000::14
cinder_api_vip: fd00:fd00:fd00:2000::14
controller_virtual_ip: 10.34.105.15
glance_api_vip: fd00:fd00:fd00:3000::15
glance_registry_vip: fd00:fd00:fd00:2000::14
gnocchi_api_vip: fd00:fd00:fd00:2000::14
heat_api_vip: fd00:fd00:fd00:2000::14
horizon_vip: fd00:fd00:fd00:2000::14
internal_api_virtual_ip: fd00:fd00:fd00:2000::14
keystone_admin_api_vip: 10.34.105.15
keystone_public_api_vip: ['fd00:fd00:fd00:2000::14', '10.34.107.18']
midonet_api_vip: fd00:fd00:fd00:2000::14
mysql_vip: fd00:fd00:fd00:2000::14
neutron_api_vip: fd00:fd00:fd00:2000::14
nova_api_vip: fd00:fd00:fd00:2000::14
nova_metadata_vip: fd00:fd00:fd00:2000::14
public_virtual_ip: ['2001:db8:fd00:1000::10', '10.34.107.18']
redis_vip: fd00:fd00:fd00:2000::18
sahara_api_vip: fd00:fd00:fd00:2000::14
storage_mgmt_virtual_ip: fd00:fd00:fd00:4000::11
storage_virtual_ip: fd00:fd00:fd00:3000::15
swift_proxy_vip: fd00:fd00:fd00:3000::15
tripleo::haproxy::controller_virtual_ip: 10.34.105.15
tripleo::haproxy::public_virtual_ip: ['2001:db8:fd00:1000::10', '10.34.107.18']
tripleo::keepalived::controller_virtual_ip: 10.34.105.15
tripleo::keepalived::internal_api_virtual_ip: fd00:fd00:fd00:2000::14
tripleo::keepalived::public_virtual_ip: ['2001:db8:fd00:1000::10', '10.34.107.18']
tripleo::keepalived::storage_mgmt_virtual_ip: fd00:fd00:fd00:4000::11
tripleo::keepalived::storage_virtual_ip: fd00:fd00:fd00:3000::15
tripleo::redis_notification::haproxy_monitor_ip: 10.34.105.15

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/347018

[Emilien Macchi (emilienm)]

Dan, is this one still valid?

[Emilien Macchi (emilienm)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (FUTURE, PIKE, QUEENS, ROCKY, STEIN).
  Valid example: CONFIRMED FOR: FUTURE