CI: delorean build of tripleo-heat-templates fails

[Sagi (Sergey) Shnaidman]

+ cp -ar deployed-server /builddir/build/BUILDROOT/openstack-tripleo-heat-templates-2.0.1-0.20160715135250.3e11fe3.el7.centos.x86_64//usr/share/openstack-tripleo-heat-templates
cp: cannot stat 'deployed-server': No such file or directory
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.FzRbJP (%install)
    Bad exit status from /var/tmp/rpm-tmp.FzRbJP (%install)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 551, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/openstack-tripleo-heat-templates.spec

should be resolved in https://review.rdoproject.org/r/#/c/1669/ but is still an issue
So keeping eye on this.

[Sagi (Sergey) Shnaidman (sshnaidm)]

Reproducing:

mkdir -p /tmp/test && cd /tmp/test
git clone https://github.com/openstack-infra/tripleo-ci
cd tripleo-ci/
TRIPLEO_ROOT=/tmp/test ./scripts/tripleo.sh --delorean-setup
STABLE_RELEASE=mitaka TRIPLEO_ROOT=/tmp/test ./scripts/tripleo.sh --delorean-build openstack/tripleo-heat-templates

[Alan Pevec (apevec)]

This is a mixup between spec and source branches, rpm-mitaka branch works with stable/mitaka.
I was looking at scripts/tripleo.sh and suspect is this part:
https://github.com/openstack-infra/tripleo-ci/blob/master/scripts/tripleo.sh#L351-L356
where local branches in the source checkout are reset to master HEAD and from the git history I don't understand why is that.

[Alan Pevec (apevec)]

Actually, it's dlrn --local in https://github.com/openstack-infra/tripleo-ci/blob/master/scripts/tripleo.sh#L361

--local does NOT reset local branches to what is specified by distro and source
parameters in projects.ini, you need have rpm-mitaka in _distro checkout to match stable/mitaka source.
But this is all using internal implementation details of DLRN tool and RDO Trunk repositories, tripleo should request features in https://github.com/openstack-packages/dlrn/issues to have a stable interface e.g. DELOREAN_DEV=1 has no effect[1] and rpm-RELEASE are going away [2]

[1] https://github.com/openstack-packages/DLRN/commit/a7b5c22f861cd260a04470e652e3034555db1f8c
[2] https://trello.com/c/URAtrhLU/86-automate-stable-packages-releases

[Sagi (Sergey) Shnaidman (sshnaidm)]

@Alan, we apply patch on repository, checkout to it and want to build this package with patch applied, it's what CI does. I suppose we used "--local" exactly for this. It doesn't make sense to run CI on patch without this patch applied.

[Sagi (Sergey) Shnaidman (sshnaidm)]

Opened an issue on delorean side: https://github.com/openstack-packages/DLRN/issues/22
It is regression.

[Alan Pevec (apevec)]

It is not a regression in DLRN tool, on July spec change on rpm-master THT was merged: https://review.rdoproject.org/r/1665 which works only with THT master source branch.
This worked before b/c rpm-master worked also with stable branches, after this change rpm-mitaka and rpm-liberty were created.

[Alan Pevec (apevec)]

https://review.openstack.org/345106 is a proposed quickfix, it's not worse than sed patching already present. Real fix is to re-review how tripleo-ci is using DLRN and provide stable interfaces for that.

[Sagi (Sergey) Shnaidman (sshnaidm)]

Look at this patch as well: https://review.openstack.org/#/c/345070/
These patches don't solve the issue, only temporary workaround, this should be solved in DLRN side and I opened the issue there: https://github.com/openstack-packages/DLRN/issues/22

If tools was used for a long time for specific purpose and after recent changes it stopped to work - it's called a regression. It doesn't matter why it happened.
Please let's find the appropriate way to fix it and provide interface to TripleO CI to use it for building packages.

[Alan Pevec (apevec)]

> Please let's find the appropriate way to fix it and provide interface to TripleO CI to use it for building packages.

tripleo-ci and dlrn need to figure this out together, I've renamed https://github.com/openstack-packages/DLRN/issues/22 to "RFE provide stable DLRN interface for TripleO CI"

[Sagi (Sergey) Shnaidman (sshnaidm)]

Remove pinning of delorean
https://review.openstack.org/#/c/349995/

[Sagi (Sergey) Shnaidman (sshnaidm)]

Fix was merged, the rest of work is tracked in https://github.com/openstack-packages/DLRN/issues/22