tripleoclient should use a generic queue name in the workflows

Bug #1603345 reported by Dougal Matthews
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Wishlist
Toure Dunnon

Bug Description

In the workflows calls behind a number of commands (openstack baremetal import, openstack baremetal introspection bulk start, and the coming soon; [1], [2], [3], [4]) a unique queue name is passed to the Mistral workflows. This queue is then used for the duration of that workflow and is destroyed afterwards.

This generally works fine, but it has one disadvantage. If the CLI uses the same queue name as the TripleO UI then all the commands on the CLI would be reflected in realtime on the UI, without need for reloading or refreshing the page. This would then make it clearer when multiple users are active and generally create a slick experience - in theory the deploy could be fully automated but with the UI open you could track progress and watch the events happen.

For this to work we need to verify that the queue is multi-consumer so that all the attached clients get the messages, and not just a random one.

[1]: https://review.openstack.org/#/c/334411
[2]: https://review.openstack.org/#/c/336595
[3]: https://review.openstack.org/#/c/339727
[4]: https://review.openstack.org/#/c/342261

Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: nobody → Dougal Matthews (d0ugal)
importance: Undecided → Low
status: New → In Progress
tags: added: spec-lite
Changed in tripleo:
importance: Low → Wishlist
status: In Progress → New
Julie Pichon (jpichon)
tags: added: tripleoclient
Dougal Matthews (d0ugal)
tags: added: workflows
Dougal Matthews (d0ugal)
Changed in tripleo:
milestone: none → ocata-1
assignee: Dougal Matthews (d0ugal) → nobody
Steven Hardy (shardy)
Changed in tripleo:
milestone: ocata-1 → ocata-2
Revision history for this message
Dougal Matthews (d0ugal) wrote :

Use the workflow stack and plan name for the default queue.

i.e. "{}-{}-{}".format(workflow_name, stack_name, plan)

Revision history for this message
Ryan Brady (rbrady) wrote :

Will the plan_name+stack_name+workflow name as a queue name work for the UI?
Will there be an issue in the future in supporting multiple overclouds?

Revision history for this message
Dougal Matthews (d0ugal) wrote :

As a follow on idea - why don't we use the workflow execution ID for the queue name? When you start a workflow with Mistral, it tells you the ID. The workflow itself can access the execution ID.

It also means you can easily look at all the running workflows and know there will be a queue for each, and you know the queue name.

Revision history for this message
Dmitry Tantsur (divius) wrote :

> As a follow on idea - why don't we use the workflow execution ID for the queue name?

+1

Changed in tripleo:
status: New → Confirmed
Changed in tripleo:
milestone: ocata-2 → ocata-3
Changed in tripleo:
status: Confirmed → Triaged
Dougal Matthews (d0ugal)
Changed in tripleo:
milestone: ocata-3 → pike-1
Changed in tripleo:
milestone: pike-1 → pike-2
Changed in tripleo:
milestone: pike-2 → pike-3
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → queens-1
Changed in tripleo:
milestone: queens-1 → queens-2
Toure Dunnon (toure)
Changed in tripleo:
assignee: nobody → Toure Dunnon (toure)
Toure Dunnon (toure)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/509902
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=1bd1620eadf23f2ee755a32a8167d9a5386a392e
Submitter: Zuul
Branch: master

commit 1bd1620eadf23f2ee755a32a8167d9a5386a392e
Author: Toure Dunnon <email address hidden>
Date: Thu Oct 5 16:48:39 2017 -0400

    Tripleoclient unified queue name.

    This will allow the cli and tripleo UI to share a common queue,
    which will help with scripting the frontend behaviour or track
    the progress of the cli from the frontend.

    Related-Bug: #1603345

    Change-Id: I5849983eee82b5a56cae1bf38a3c2694b6b291db

Dougal Matthews (d0ugal)
Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.