inspection_enable_uefi option is not passed to Puppet on Mitaka and Liberty

[Miles Gould]

The inspection_enable_uefi configuration option in undercloud.conf is meant to set the ironic::inspector::enable_uefi Puppet variable, turning on UEFI support in ironic-inspector. However, in Mitaka, ironic::inspector::enable_uefi is always set to an empty string.

The patch to add this option was https://review.openstack.org/#/c/319348/. This was backported to Mitaka in https://review.openstack.org/#/c/321118/ (merged) and to Liberty in https://review.openstack.org/#/c/321119/ (not yet merged). The original patch depended on the code in https://review.openstack.org/#/c/297319/ ("Generate most of the pystache context automatically"), which has not been backported to Mitaka or Liberty.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/337243

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/337250

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337243
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=520c96759237b4baac6cd8c5b7a3c04e1e1b94fb
Submitter: Jenkins
Branch: stable/mitaka

commit 520c96759237b4baac6cd8c5b7a3c04e1e1b94fb
Author: Ben Nemec <email address hidden>
Date: Thu Mar 24 19:09:30 2016 +0000

    Generate most of the pystache context automatically

    For the most part, the pystache context is just a list of values from
    undercloud.conf. Rather than maintain this list manually, including
    duplicate default values (some of which are bad, like the "unset"
    password defaults), let's just generate the context dict based on
    the options we can look up from undercloud.py.

    This also avoids masking mistakes where a value is added to the
    context, but a corresponding config opt is not added to
    undercloud.conf, resulting in an unconfigurable "option".

    Closes-Bug: 1598846
    Change-Id: I70cc0f98e4f869417e22270a71f1f18525a06aac
    (cherry picked from commit c03d2ccbbc46398b898f6fbaf90e296e749a4ca8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337250
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=c6afcc818e55d127932613a37c1bcb58ac472c08
Submitter: Jenkins
Branch: stable/liberty

commit c6afcc818e55d127932613a37c1bcb58ac472c08
Author: Ben Nemec <email address hidden>
Date: Thu Mar 24 19:09:30 2016 +0000

    Generate most of the pystache context automatically

    For the most part, the pystache context is just a list of values from
    undercloud.conf. Rather than maintain this list manually, including
    duplicate default values (some of which are bad, like the "unset"
    password defaults), let's just generate the context dict based on
    the options we can look up from undercloud.py.

    This also avoids masking mistakes where a value is added to the
    context, but a corresponding config opt is not added to
    undercloud.conf, resulting in an unconfigurable "option".

    Closes-Bug: 1598846
    Change-Id: I70cc0f98e4f869417e22270a71f1f18525a06aac
    (cherry picked from commit c03d2ccbbc46398b898f6fbaf90e296e749a4ca8)
    (cherry picked from commit ecb3d7e23db363c8a8a8dc2ade84f5531377da9e)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/instack-undercloud 4.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 4.2.0 release.