stable jobs on rh2 have invalid sudoers file

[Derek Higgins]

Stable Jobs running on rh2 are failing due to a malformed sudoers file

from http://logs.openstack.org/76/335876/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-ha/e562c5b/console.html#_2016-07-01_07_50_27_396426

sudo: >>> /etc/sudoers: syntax error near line 9 <<<
sudo: parse error in /etc/sudoers near line 9
sudo: no valid sudoers sources found, quitting
sudo: unable to initialize policy plugin

the problem is that the infra images (which is the undercloud on rh2) have quotes surrounding secure_path

Defaults secure_path="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

in instack-undercloud/elements/undercloud-install/pre-install.d/01-usr-local-bin-secure-path
we append /usr/local/bin
Defaults secure_path="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin":/usr/local/bin

but it needs to be before the closing quote

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/336469

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/336470

[Steven Hardy (shardy)]

Assigning to me as Derek is out on PTO and we need to track landing the fixes before rh1 gets relocated

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336469
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=82ab0a147a90b8b50f1f09c1a4bd1321a355817b
Submitter: Jenkins
Branch: stable/mitaka

commit 82ab0a147a90b8b50f1f09c1a4bd1321a355817b
Author: Derek Higgins <email address hidden>
Date: Fri Jul 1 11:07:06 2016 +0100

    Maintain quotes if present at end of secure_path

    When adding /usr/local/bin to secure_path place it before the closing
    quote if one is present.

    Change-Id: I6a37d81da1ee23170dd17125b2e6322d9a28ddbe
    Closes-Bug: #1598089

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336470
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=848afaa38a8999e341c6ba7e291926e8cd5c3b84
Submitter: Jenkins
Branch: stable/liberty

commit 848afaa38a8999e341c6ba7e291926e8cd5c3b84
Author: Derek Higgins <email address hidden>
Date: Fri Jul 1 11:07:06 2016 +0100

    Maintain quotes if present at end of secure_path

    When adding /usr/local/bin to secure_path place it before the closing
    quote if one is present.

    Change-Id: I6a37d81da1ee23170dd17125b2e6322d9a28ddbe
    Closes-Bug: #1598089

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/instack-undercloud 4.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 4.2.0 release.