Cannot update Ironic nodes via baremetal import

[Ben Nemec]

If you try to update Ironic node info using openstack baremetal import, it will likely fail with the following message:

[centos@undercloud-demo ~]$ openstack baremetal import --json instackenv.json
Invalid node data: Several candidates found for the same node data: [u'03d75481-db17-40db-8a61-af8ff71e83cf', u'03d75481-db17-40db-8a61-af8ff71e83cf']

This is due to the fact that tripleo_common.nodes uses a list when looking for the node id based on the details passed in, but checks multiple fields and thus adds the same node to the list multiple times. Changing that operation to use a set instead should fix the problem.

[Ben Nemec (bnemec)]

https://review.openstack.org/#/c/322327/

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tripleo-common 5.0.0.0b1 development milestone.

[Ronelle Landy (rlandy)]

I just this error on Mitaka installation (openstack-tripleo-common-2.0.1-0.20160614154404.d87771a.el7.centos.noarch):

+ openstack baremetal import --json instackenv.json
Invalid node data: Several candidates found for the same node data: [u'043cdf2b-b515-4e44-8681-a58524239807', u'043cdf2b-b515-4e44-8681-a58524239807']

I hit this error on a clean install - no upgrades involved. I see that there is a fix for Newton. Any thoughts to back-porting this to fix to Mitaka?

[Ben Nemec (bnemec)]

I would consider this a valid backport candidate. I'll try to get it proposed sometime today.

[Ben Nemec (bnemec)]

Mitaka backport here: https://review.openstack.org/#/c/330717/

[Ronelle Landy (rlandy)]

Thank you bnemec: Mitaka release with backport available today - works for me

[Ben Nemec (bnemec)]

Note that this problem does not appear to be present in the Liberty release, so no backport is required there.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tripleo-common 2.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 2.1.0 release.