The default for installing puppet modules in instack-undercloud was changed to source

[John Trowbridge]

We changed the default way that puppet modules are installed from package to source. [1]

This is because the element we switched to [2] does not have an export for puppet modules' install type, and the puppet module element does not seem to respect the default install type [3].

I am not sure whether this is better to fix in tripleo-image-elements or tripleo-puppet-elements.

[1] https://github.com/openstack/instack-undercloud/commit/3083c864c9beac7edf9a4efa6242e51c688d2fc0
[2] https://github.com/openstack/tripleo-image-elements/blob/master/elements/enable-packages-install/environment.d/01-export-install-types.bash
[3] https://github.com/openstack/tripleo-puppet-elements/blob/master/elements/puppet-modules/environment.d/01-puppet-modules-install-types.sh#L1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/318293

[James Slagle (james-slagle)]

patch: https://review.openstack.org/#/c/318293/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318293
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=3b52cd4b4bfeb9b3f513db31083cf4ed01a8b09a
Submitter: Jenkins
Branch: master

commit 3b52cd4b4bfeb9b3f513db31083cf4ed01a8b09a
Author: James Slagle <email address hidden>
Date: Wed May 18 15:07:20 2016 -0400

    Honor $DIB_DEFAULT_INSTALLTYPE in puppet-modules

    Makes the puppet-modules element honor the $DIB_DEFAULT_INSTALLTYPE
    environment variable. This environment variable is set to source by
    default.

    Other elements, such as the enable-packages-install element may set it
    to package.

    Since the enable-packages-install element sets it to package at
    01-export-install-types.bash[1], 01-puppet-modules-install-types.sh is
    moved to 02-puppet-modules-install-types.sh so that it runs later.

    Closes-Bug: 1583263
    [1] https://github.com/openstack/tripleo-image-elements/blob/master/elements/enable-packages-install/environment.d/01-export-install-types.bash

    Change-Id: I1d14fc9b113d45e7ab613f44011f442e4436a904

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tripleo-puppet-elements 5.0.0.0b1 development milestone.