Refactor common things from tripleo-common to ironicclient

Bug #1582250 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Invalid
Wishlist
Harish Kumar

Bug Description

We have a variety of functions in tripleo-common related to managing groups of ironic nodes, for example https://review.openstack.org/#/c/309521/ has nodes.wait_for_provision_state which seems not specific to TripleO, and there are several other examples which could potentially be refactored out of tripleo-common into ironicclient.

This bug can be used to enumerate those functions or features we may want to migrate out of tripleo-common to ironicclient, and track landing patches to do it.

Steven Hardy (shardy)
Changed in tripleo:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: ironic-cleanups low-hanging-fruit
Changed in tripleo:
milestone: none → newton-3
Steven Hardy (shardy)
Changed in tripleo:
milestone: newton-3 → ongoing
Harish Kumar (hkumarmk)
Changed in tripleo:
assignee: nobody → Harish Kumar (hkumarmk)
Revision history for this message
Harish Kumar (hkumarmk) wrote :

Hi shardy et all,

I am newbie in openstack dev and trying to work on this.

I am trying to understand the stuffs need to be done, I am taking the method you mentioned in the description (wait_for_provision_state), I have some confusions here - it is great if somebody could please give me some pointers.

1. Where is this method getting used? I don't see them used in python-tripleoclient (I see it defined that function there) or anywhere in tripleo-common.
2. Why tripleoclient has its own method and why its not used from tripleo-common (or may be directly from ironicclient)?

It would be helpful to understand where it is get used to understand the impact of this code movement.

Thank you very much, Harish

Revision history for this message
Emilien Macchi (emilienm) wrote :

This bug was last updated over 180 days ago, as tripleo is a fast moving project and we'd like to get the tracker down to currently actionable bugs, this is getting marked as Invalid. If the issue still exists, please feel free to reopen it.

Changed in tripleo:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.