Network configuration is all messed up

[Lars Kellogg-Stedman]

We appear to be completely ignoring the undercloud_external_network_cidr setting when deploying the overcloud. This leads to deployment failures if you try setting this. This is partly related to the network_isolation support, but I'm not entirely sure of all the moving parts.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316264

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316264
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=da478388da0645a5cc1f47513e54dca3ef8fcfdb
Submitter: Jenkins
Branch: master

commit da478388da0645a5cc1f47513e54dca3ef8fcfdb
Author: Lars Kellogg-Stedman <email address hidden>
Date: Fri May 13 15:56:31 2016 -0400

    fix network configuration

    When deploying with `network_isolation: true`, we are failing to pass
    in the network settings from our configuration into the tripleo
    deployment process, leading ultimately to deployment failures when
    attempting to use non-default values.

    additionally, setting `network_isolation: true` required adding a
    number of explicit arguments to `extra_args`, so it was not possible
    to control the use of network isolation simply by toggling the value
    of `network_isolation`.

    This commits allows the deployment to succeed with `network_isolation`
    either disabled or enabled, and allows the use of non-default values
    for the network configuration.

    Change-Id: I68f5a87e390aa2ea8d8c5631eba17dc5dd44270e
    Closes-bug: #1581659