tripleo

Management Network value specs has wrong param type

Bug #1573649 reported by Matt Wisch
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Matt Wisch
tripleo newton-1 "newton-1"
Liberty
Fix Released
Undecided
Matt Wisch
Mitaka
Fix Released
Undecided
Matt Wisch

Bug Description

When deploying a tripleo overcloud that includes a Management Network, you will receive the error:

"Property error: resources.ManagementNetwork.properties.ManagementNetValueSpecs: Value must be a string"

The network value specs, to include the default are passed in in JSON format. All that is missing is to change the type from string to json in the networks/management.yaml template.

Matt Wisch (matt-wisch)
Changed in tripleo:
status: New → In Progress
assignee: nobody → Matt Wisch (matt-wisch)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/309468

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/309549

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/309563

Steven Hardy (shardy)
Changed in tripleo:
importance: Undecided → High
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/309468
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=26d8931ffd1e7e036f07ef6fac9b364f09cbf783
Submitter: Jenkins
Branch: master

commit 26d8931ffd1e7e036f07ef6fac9b364f09cbf783
Author: Matt Wisch <email address hidden>
Date: Fri Apr 22 11:09:56 2016 -0400

    Fix the ManagementNetValueSpecs param type

    The ManagementNetValueSpecs param type is currently set to string.
    This change sets the param to the correct type of json, allowing the
    network value specs to correctly parse.

    Example Management Network value spec:

    {'provider:physical_network': 'management', 'provider:network_type': 'flat'}

    Change-Id: I5b12c7251690368d79a4d00725a9d6e0d5e75af8
    Closes-Bug: #1573649

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/mitaka)

Reviewed: https://review.openstack.org/309563
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1a155adbc46a6041bc0ebd703fe0fefff5131bd0
Submitter: Jenkins
Branch: stable/mitaka

commit 1a155adbc46a6041bc0ebd703fe0fefff5131bd0
Author: Matt Wisch <email address hidden>
Date: Fri Apr 22 11:09:56 2016 -0400

    Fix the ManagementNetValueSpecs param type

    The ManagementNetValueSpecs param type is currently set to string.
    This change sets the param to the correct type of json, allowing the
    network value specs to correctly parse.

    Example Management Network value spec:

    {'provider:physical_network': 'management', 'provider:network_type': 'flat'}

    Change-Id: I5b12c7251690368d79a4d00725a9d6e0d5e75af8
    Closes-Bug: #1573649

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tripleo-heat-templates 5.0.0.0b1

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/liberty)

Reviewed: https://review.openstack.org/309549
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=803337432a1ea76202e81bc49e163ad8407c7558
Submitter: Jenkins
Branch: stable/liberty

commit 803337432a1ea76202e81bc49e163ad8407c7558
Author: Matt Wisch <email address hidden>
Date: Fri Apr 22 11:09:56 2016 -0400

    Fix the ManagementNetValueSpecs param type

    The ManagementNetValueSpecs param type is currently set to string.
    This change sets the param to the correct type of json, allowing the
    network value specs to correctly parse.

    Example Management Network value spec:

    {'provider:physical_network': 'management', 'provider:network_type': 'flat'}

    Change-Id: I5b12c7251690368d79a4d00725a9d6e0d5e75af8
    Closes-Bug: #1573649

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tripleo-heat-templates 2.1.0

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/tripleo-heat-templates 2.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.