Inconsistent use of parameter_defaults in environment files

Bug #1567837 reported by Jiří Stránský
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Dan Prince

Bug Description

In the environments/ subdirectory of tripleo-heat-templates, we mostly use parameter_defaults, but some of the environment files still use parameters. This can lead to confusing behavior with respect to parameter priority when passing environment files to deploy/update commands. Users might expect that subsequent environment files take priority over preceding ones, but that might not be the case if the preceding environment files use `parameters`, while the subsequent ones use `parameter_defaults`.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/303305

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Dan Prince (dan-prince) wrote :

I've started fixing these as part of the composable services stuff as well (because it is a requirement for me).

Changed in tripleo:
assignee: Jiří Stránský (jistr) → Dan Prince (dan-prince)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/303305
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a12087715f0fe4251a95ab67120023d553c24a45
Submitter: Jenkins
Branch: master

commit a12087715f0fe4251a95ab67120023d553c24a45
Author: Jiri Stransky <email address hidden>
Date: Fri Apr 8 10:59:07 2016 +0200

    Always use parameter_defaults in environment files

    In the environments/ subdirectory of tripleo-heat-templates, we mostly
    use parameter_defaults, but some of the environment files still use
    parameters. This can lead to confusing behavior with respect to
    parameter priority when passing environment files to deploy/update
    commands. Users might expect that subsequent environment files take
    priority over preceding ones, but that might not be the case if the
    preceding environment files use `parameters`, while the subsequent ones
    use `parameter_defaults`.

    This commit switches all `parameters:` uses in environments/
    subdirectory to `parameter_defaults:`.

    Change-Id: Ie4c03c7e7f5a5004a0384d35817135f357e9719b
    Closes-Bug: #1567837

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tripleo-heat-templates 5.0.0.0b1

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers