os-collect-config not covered in CI

[James Slagle]

It seems that os-collect-config is not covered by CI for some reason.

We merged https://review.openstack.org/#/c/294069/ which appeared to pass CI, but once delorean built a new package of os-collect-config all of our CI jobs started failing with a traceback when os-collect-config tried to start on the deployed overcloud nodes:

Mar 21 17:50:03 overcloud-controller-0 systemd[1]: Starting Collect metadata and run hook commands....
Mar 21 17:50:04 overcloud-controller-0 os-collect-config[4530]: Traceback (most recent call last):
Mar 21 17:50:04 overcloud-controller-0 os-collect-config[4530]: File "/usr/bin/os-collect-config", line 10, in <module>
Mar 21 17:50:04 overcloud-controller-0 os-collect-config[4530]: sys.exit(__main__())
Mar 21 17:50:04 overcloud-controller-0 os-collect-config[4530]: File "/usr/lib/python2.7/site-packages/os_collect_config/collect.py", line 237, in __main__
Mar 21 17:50:04 overcloud-controller-0 os-collect-config[4530]: log.setup("os-collect-config")
Mar 21 17:50:04 overcloud-controller-0 os-collect-config[4530]: TypeError: setup() takes at least 2 arguments (1 given)
Mar 21 17:50:04 overcloud-controller-0 systemd[1]: os-collect-config.service: main process exited, code=exited, status=1/FAILURE
Mar 21 17:50:04 overcloud-controller-0 systemd[1]: Unit os-collect-config.service entered failed state.
Mar 21 17:50:04 overcloud-controller-0 systemd[1]: os-collect-config.service failed.
Mar 21 17:50:04 overcloud-controller-0 systemd[1]: os-collect-config.service holdoff time over, scheduling restart.

There was a patch to fix the actual error:
https://review.openstack.org/#/c/295507/

But that fails CI the same way, indicating that we aren't even testing proposed patches to os-collect-config.

I quickly approved the revert:
https://review.openstack.org/#/c/295508/

until we figure out to fix the coverage, then we can re-propose the patch.

[Steven Hardy (shardy)]

I see the same, installing os-collect-config on the undercloud gets a latest 0.1.38 delorean package, but my overcloud-full image (freshly built on the same undercloud) gets an old 0.1.28-1 package.

[Steven Hardy (shardy)]

Ok my issue seems unrelated, I forgot to build via tripleo.sh and thus overcloud image build was using the wrong repos.

[Derek Higgins (derekh)]

Looks like we haven't been testing any of the 4 os-*-config reviews since moving to tripleo.sh (last September)
fixed here https://review.openstack.org/#/c/309092/