hacluster user conflict between t-h-t and puppet-pacemaker

[Ben Nemec]

https://github.com/openstack/puppet-pacemaker/commit/8d2f1dfa87d49ffafaeccacb057416f03c829415 added an hacluster user definition, but tripleo-heat-templates also defines that user https://github.com/openstack/tripleo-heat-templates/blob/b0ba9e8e09d70cb5871a6f343a698e3b481ac297/puppet/manifests/overcloud_controller_pacemaker.pp#L71

This is resulting in the ha job failing with: Error: Duplicate declaration: User[hacluster] is already declared in file /var/lib/heat-config/heat-config-puppet/c0b26626-4e80-436e-9226-28a5fc8e78ca.pp:73; cannot redeclare at /etc/puppet/modules/pacemaker/manifests/corosync.pp:121 on node overcloud-controller-0.localdomain

Strangely, https://review.openstack.org/#/c/281376/ passed the ha job, which makes me wonder if we're actually testing the proposed change on that repo. Based on this, I'm thinking not.

So I think we have two problems here: 1) The tripleo HA job is broken. We probably need a quick revert of the puppet-pacemaker change to get past that, and 2) It appears we aren't properly testing changes in puppet-pacemaker. We need to figure out why and fix that too.

[Ben Nemec (bnemec)]

It looks like we only use the puppet modules from /opt/stack/new, which doesn't include puppet-pacemaker right now. Pushing a change to add it to our infra project list so it will be included.

[Ben Nemec (bnemec)]

Infra change that I'm hoping will make this work: https://review.openstack.org/293749