Default undercloud control plane network violates rfc5737

[Adam Young]

The default control plan is 192.0.2.0/24 which is not supposedto be used, it is only for documentation purposes according to rfc5737:

https://tools.ietf.org/html/rfc5737

"Addresses within the TEST-NET-1, TEST-NET-2, and TEST-NET-3 blocks
   SHOULD NOT appear on the public Internet and are used without any
   coordination with IANA or an Internet registry [RFC2050]. Network
   operators SHOULD add these address blocks to the list of non-
   routeable address spaces, and if packet filters are deployed, then
   this address block SHOULD be added to packet filters.

   These blocks are not for local use, and the filters may be used in
   both local and public contexts."

It breaks tools that enforce the filters.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/289221

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320072
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=139f1f36c82607ed575733019e380ddd98e60d39
Submitter: Jenkins
Branch: master

commit 139f1f36c82607ed575733019e380ddd98e60d39
Author: Ben Nemec <email address hidden>
Date: Mon May 23 18:11:14 2016 +0000

    Deprecate default 192.0.2.0/24 CIDR

    This is a non-routable CIDR per RFC 5737, so we shouldn't be using
    it by default. However, if we just change it and don't provide a
    deprecation period we may break users who have deployed with the
    default CIDR, so we should give them a cycle to update their
    configs appropriately.

    This changes the default of network_cidr to None so that we can
    detect when a user has not changed our default, and sets the
    appropriate override to maintain backwards compatibility in that
    case. It also prints a warning about the deprecation at the end
    of the deploy process, when it is most likely to be noticed.

    Change-Id: I931a1f7160a007d367621de5cc1034c56c7741cf
    Partial-Bug: 1553222

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/289221