Environment files should not need to be passed to every command

[Zane Bitter]

With the improvements for bug 1224828 in Liberty, Heat now supports retaining the existing environment during a PATCH (not PUT) update. This should enable users to omit passing extra environment files to every tripleoclient command that performs a stack update on pain of destroying their deployment. However, in order to take advantage of that, the client needs to stop automatically including the default environment files on updates, since that reverses any overrides that the user might have included in extra environment files.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226306
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0309bea1acc816cdfa04253e55efb1fde237c27d
Submitter: Jenkins
Branch: master

commit 0309bea1acc816cdfa04253e55efb1fde237c27d
Author: Jan Provaznik <email address hidden>
Date: Tue Sep 22 14:47:43 2015 +0200

    Don't send default environment file on stack update

    With the improvements for bug #1224828 in Liberty, Heat now remembers
    the stack's environment so there is no need to pass all environment
    files on every update of overcloud.

    Since user can now omit all the '-e' arguments on update operations
    we also should not send the "basic" resource registry environment
    file either because if only this file is passed on update operation
    (without all the extra env files passed on create), it may cause that
    resource_registry for some resources will be changed which causes
    that existing resources to be replaced with new ones.

    Change-Id: I2e2da03e6a36f3bc46bb608350e11f5431e0fcff
    Closes-Bug: #1498607

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/238231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238231
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=6cdae2f901e3329f6c5f66f78558101da596507b
Submitter: Jenkins
Branch: master

commit 6cdae2f901e3329f6c5f66f78558101da596507b
Author: Steve Baker <email address hidden>
Date: Wed Oct 21 16:22:15 2015 +1300

    Include registry on update when other envs are specified

    On an openstack overcloud deploy which results in a stack-update,
    implicitly include overcloud-resource-registry-puppet.yaml if the user
    specifies any other custom environments. Do not include
    overcloud-resource-registry-puppet.yaml if the user specifies no extra
    environments.

    This solution would be an improvement over the current situation, but it
    isn't perfect.

    It does the right thing when:
    - the user does an openstack overcloud with no environments specified
    - the user does an openstack overcloud with all custom environments
      specified

    It will sometimes do the wrong thing when:
    - the user specifies a partial list of custom environments (like -e
      do_my_custom_oneoff_thing.yaml)

    Change-Id: I60fbf2182429f6bb83e000fc4d45269d7f83171b
    Related-Bug: #1498607
    Closes-Bug: #1504363

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/257076

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257076
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ceafb5847a176f6b0ed2283c62a46c9ea63810bd
Submitter: Jenkins
Branch: stable/liberty

commit ceafb5847a176f6b0ed2283c62a46c9ea63810bd
Author: Steve Baker <email address hidden>
Date: Wed Oct 21 16:22:15 2015 +1300

    Include registry on update when other envs are specified

    On an openstack overcloud deploy which results in a stack-update,
    implicitly include overcloud-resource-registry-puppet.yaml if the user
    specifies any other custom environments. Do not include
    overcloud-resource-registry-puppet.yaml if the user specifies no extra
    environments.

    This solution would be an improvement over the current situation, but it
    isn't perfect.

    It does the right thing when:
    - the user does an openstack overcloud with no environments specified
    - the user does an openstack overcloud with all custom environments
      specified

    It will sometimes do the wrong thing when:
    - the user specifies a partial list of custom environments (like -e
      do_my_custom_oneoff_thing.yaml)

    Change-Id: I60fbf2182429f6bb83e000fc4d45269d7f83171b
    Related-Bug: #1498607
    Closes-Bug: #1504363