[tripleoclient] DIB includes the "in-tree" elements by default

[John Trowbridge]

The default provided for --elements-path includes '/usr/share/diskimage-builder/elements'. However, diskimage-builder will include this path by default. In my environment it is including it as '/usr/bin/../share/diskimage-builder/elements'. This will cause any element with a svc-map to fail with duplicate svc-map entries.

This is arguably a bug in DIB, but it is very easy to just not include that path in the default --elements-path, since it will get included anyways.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222223

[Ben Nemec (bnemec)]

FWIW, I don't consider this a bug in DIB. I'm not sure it's actually possible to build an image without _any_ built-in dib elements, and even if it is that's a serious edge case. I believe this is also the documented behavior of ELEMENTS_PATH.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222223
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b82117097cca70b08c2385c861dcdc307558daa7
Submitter: Jenkins
Branch: master

commit b82117097cca70b08c2385c861dcdc307558daa7
Author: John Trowbridge <email address hidden>
Date: Thu Sep 10 10:38:44 2015 -0400

    DIB includes the "in-tree" elements by default

    The default provided for --elements-path includes
    '/usr/share/diskimage-builder/elements'. However,
    diskimage-builder will include this path by default. This
    will cause any element with a svc-map to fail with
    duplicate svc-map entries.

    This patch removes '/usr/share/diskimage-builder/elements'
    from the default for --elements-path.

    Change-Id: I388b564cb05f8bdb4006ac29df4837738453109a
    Closes-Bug: #1494349