Error: Invalid parameter warn on Concat failing puppet jobs

[James Slagle]

Failed log from an overcloud controller:
http://logs.openstack.org/48/173248/3/check-tripleo/check-tripleo-ironic-overcloud-f20puppet-nonha/86408d9/logs/ov-mfsp4hmvx4s-0-vabectvfchwd-Controller_logs/os-collect-config.txt.gz

Error:
Apr 15 16:25:57 ov-mfsp4hmvx4s-0-vabectvfchwd-controller-dc2u7twlslrx os-collect-config[836]: [2015-04-15 16:25:57,787] (heat-config) [INFO] {"deploy_stdout": "", "deploy_stderr": "\u001b[1;31mWarning: Variable access via 'notification_email_to' is deprecated. Use '@notification_email_to' instead. template[/etc/puppet/modules/keepalived/templates/global_config.erb]:3\n (at /usr/share/ruby/vendor_ruby/puppet/parser/templatewrapper.rb:76:in `method_missing')\u001b[0m\n\u001b[1;31mWarning: notify is a metaparam; this value will inherit to all contained resources in the keepalived::instance definition\u001b[0m\n\u001b[1;31mError: Invalid parameter warn on Concat[/etc/keepalived/keepalived.conf] at /etc/puppet/modules/keepalived/manifests/config.pp:12 on node ov-mfsp4hmvx4s-0-vabectvfchwd-controller-dc2u7twlslrx.novalocal\nWrapped exception:\nInvalid parameter warn\u001b[0m\n\u001b[1;31mError: Invalid parameter warn on Concat[/etc/keepalived/keepalived.conf] at /etc/puppet/modules/keepalived/manifests/config.pp:12 on node ov-mfsp4hmvx4s-0-vabectvfchwd-controller-dc2u7twlslrx.novalocal\u001b[0m\n", "deploy_status_code": 1}

[James Slagle (james-slagle)]

I think this is the commit that is breaking us:
https://github.com/puppetlabs/puppetlabs-concat/commit/9970cc6550735370666553cb043656bb945bef7b

I've submitted a pin in tripleo-ci:
https://review.openstack.org/#/c/173990

[James Slagle (james-slagle)]

from irc:

16:46 < greghaynes> slagle: dprince Just pinged buddy here who authored the upstream puppet patch - he says 1.2.x is the stable branch we should be using
16:46 < greghaynes> and apparently that means were using 2.x

[Hunter Haugen (hunner)]

This error is caused by passing the warn attribute to the concat defined resource. The master branch holds the soon-to-be-released code of 2.0.0, and warn has been renamed to warn_header.

[James Slagle (james-slagle)]

i think the long term fix here is to switch to the stable branches for these modules