port not added to bridge after a reboot

[Ed Bak]

After a reboot of the seed node, a port is missing from the ovs bridge.

Before reboot:

    Bridge br-int
        fail_mode: secure
        Port "tap5b71f0d6-fc"
            tag: 1
            Interface "tap5b71f0d6-fc"
                type: internal
        Port br-int
            Interface br-int
                type: internal
        Port int-br-ctlplane
            Interface int-br-ctlplane
                type: patch
                options: {peer=phy-br-ctlplane}
    Bridge br-ctlplane
        Port phy-br-ctlplane
            Interface phy-br-ctlplane
                type: patch
                options: {peer=int-br-ctlplane}
        Port "eth1"
            Interface "eth1"
        Port br-ctlplane
            Interface br-ctlplane
                type: internal
    ovs_version: "2.1.0"

After reboot ( eth1 is missing ):

    Bridge br-int
        fail_mode: secure
        Port "tap5b71f0d6-fc"
            tag: 1
            Interface "tap5b71f0d6-fc"
                type: internal
        Port br-int
            Interface br-int
                type: internal
        Port int-br-ctlplane
            Interface int-br-ctlplane
                type: patch
                options: {peer=phy-br-ctlplane}
    Bridge br-ctlplane
        Port phy-br-ctlplane
            Interface phy-br-ctlplane
                type: patch
                options: {peer=int-br-ctlplane}
        Port br-ctlplane
            Interface br-ctlplane
                type: internal
    ovs_version: "2.1.0"

/etc/network/interfaces

# interfaces(5) file used by ifup(8) and ifdown(8)
# Include files from /etc/network/interfaces.d:
source-directory /etc/network/interfaces.d
auto br-ctlplane
allow-ovs br-ctlplane
iface br-ctlplane inet static
 pre-up ip addr flush dev eth1
 address 10.22.170.99
 netmask 255.255.255.0
 ovs_type OVSBridge
 ovs_extra set bridge br-ctlplane other-config:hwaddr=00:ba:0c:59:fe:ca

auto eth1
allow-br-ctlplane eth1
 iface eth1 inet manual
 ovs_bridge br-ctlplane
 ovs_type OVSPort

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123534

[Marios Andreou (marios-b)]

FYI, (from the discussion @ https://review.openstack.org/#/c/123534 - thanks to Ashok kumaran B) - it is recommended not to add 'auto' for ovs bridges - see [1] (grep: an admin should not add openvswitch bridges in the 'auto' ... )

[1] https://github.com/openvswitch/ovs/blob/9a8b5cc1a3d941c0e33f3f5b5ac260a35a8130af/debian/openvswitch-switch.README.Debian#L225

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123534
Committed: https://git.openstack.org/cgit/openstack/tripleo-image-elements/commit/?id=c8f98bd70418edb11ac3fa047b9dff3a1cfbf992
Submitter: Jenkins
Branch: master

commit c8f98bd70418edb11ac3fa047b9dff3a1cfbf992
Author: Ed Bak <email address hidden>
Date: Tue Sep 23 12:12:43 2014 -0600

    ensure that port is added to bridge after a reboot

    This is a change to the interfaces file to allow
    openvswitch to start the ovs-bridge and to add the
    specified ports. Without this change, the bridge
    comes up after a reboot of the seed or undercloud,
    but the port associated with the physical interface
    doesn't come up.

    Change-Id: Ic968f39b16934c9e55d9aa448cbd9de54f659d4d
    Closes-Bug: 1373063
    Co-Authored-By: Ashok kumaran B<email address hidden>