CI tests are pulling in the wrong version of git repo's

[Derek Higgins]

If the project which triggered CI is being pulled into an image by source-repositories we end up pulling in an incorrect version.

See https://review.openstack.org/#/c/118252/2
http://logs.openstack.org/52/118252/2/experimental-tripleo/check-tripleo-novabm-undercloud-precise-nonha/d773ac1/console.html#_2014-09-02_09_06_11_198
2014-09-02 09:06:11.198 | HEAD is now at 5042399 Merge "Apic drivers enhancements (second approach): Sync"

It should be "Supply missing cisco_cfg_agent.ini file"

Confirmed here (where pip reports the tarball version)
http://logs.openstack.org/52/118252/2/experimental-tripleo/check-tripleo-novabm-undercloud-precise-nonha/d773ac1/console.html#_2014-09-02_09_13_15_261
2014-09-02 09:13:15.261 | Requirement already satisfied (use --upgrade to upgrade): pbr>=0.6,!=0.7,<1.0 in /opt/stack/venvs/openstack/lib/python2.7/site-packages (from neutron==2014.2.dev480.g5042399)

This is because devstack-gate leaves the git repository in a detached head state,
http://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/functions.sh#n298

http://logs.openstack.org/52/118252/2/experimental-tripleo/check-tripleo-ironic-undercloud-precise-nonha/49c3e21/logs/devstack-gate-setup-workspace-new.txt.gz

2014-09-02 08:57:42.208 | + git_fetch_at_ref openstack/neutron refs/zuul/master/Z768e793b39f448c295d89b4919192367
2014-09-02 08:57:42.210 | + local project=openstack/neutron
2014-09-02 08:57:42.211 | + local ref=refs/zuul/master/Z768e793b39f448c295d89b4919192367
2014-09-02 08:57:42.212 | + '[' refs/zuul/master/Z768e793b39f448c295d89b4919192367 '!=' '' ']'
2014-09-02 08:57:42.213 | + git fetch http://zm01.openstack.org/p/openstack/neutron refs/zuul/master/Z768e793b39f448c295d89b4919192367
2014-09-02 08:57:42.214 | From http://zm01.openstack.org/p/openstack/neutron
2014-09-02 08:57:42.216 | * branch refs/zuul/master/Z768e793b39f448c295d89b4919192367 -> FETCH_HEAD
2014-09-02 08:57:42.217 | + return 0
2014-09-02 08:57:42.218 | + git_checkout openstack/neutron FETCH_HEAD
2014-09-02 08:57:42.219 | + local project=openstack/neutron
2014-09-02 08:57:42.220 | + local branch=FETCH_HEAD
2014-09-02 08:57:42.222 | + local reset_branch=FETCH_HEAD
2014-09-02 08:57:42.223 | + [[ FETCH_HEAD != \F\E\T\C\H\_\H\E\A\D ]]
2014-09-02 08:57:42.224 | + git checkout FETCH_HEAD
2014-09-02 08:57:42.226 | Note: checking out 'FETCH_HEAD'.
2014-09-02 08:57:42.227 |
2014-09-02 08:57:42.228 | You are in 'detached HEAD' state. You can look around, make experimental
2014-09-02 08:57:42.229 | changes and commit them, and you can discard any commits you make in this
2014-09-02 08:57:42.230 | state without impacting any branches by performing another checkout.
2014-09-02 08:57:42.232 |
2014-09-02 08:57:42.233 | If you want to create a new branch to retain commits you create, you may
2014-09-02 08:57:42.234 | do so (now or later) by using -b with the checkout command again. Example:
2014-09-02 08:57:42.235 |
2014-09-02 08:57:42.236 | git checkout -b new_branch_name
2014-09-02 08:57:42.238 |
2014-09-02 08:57:42.239 | HEAD is now at 1a31f22... Supply missing cisco_cfg_agent.ini file
2014-09-02 08:57:42.240 | + git reset --hard FETCH_HEAD
2014-09-02 08:57:44.807 | HEAD is now at 1a31f22 Supply missing cisco_cfg_agent.ini file

This effects pretty much all of the repositories that we have in the experimental queue, instead of what was expected we end up testing the git commit that was at master when the nodepool template was built.

[Jon-Paul Sullivan (jonpaul-sullivan)]

Can we use set-source-vars to set the DIB_REPOREF_* and DIB_REPOLOCATION_* pointing at the correct repo?

[Derek Higgins (derekh)]

Fix proposed https://review.openstack.org/#/c/118375/

[Derek Higgins (derekh)]

fix merged