tripleo-heat-templates broken on even one-month old underclouds

[Robert Collins]

+ heat stack-update -e /home/shared/overcloud-env.json -t 360 -f /home/shared/tripleo-heat-templates/overcloud.yaml -P ExtraConfig= ci-overcloud
ERROR: The template version is invalid: "heat_template_version: 2014-10-16". "heat_template_version" should be: 2013-05-23

This will make it very hard for folk to upgrade (a) since we haven't got upgrades on the undercloud tested yet, and b) we don't have an upgradeable seed and c) there's nowhere to poke to deploy new undercloud *without requiring it be upgraded before we do the upgraded*)

[Tomas Sedovic (tsedovic)]

The HOT templates require the "list_join" (a Fn::Join equivalent) intrinsic function, which is only available in template version 2014-10-16.

[Robert Collins (lifeless)]

Ok, so we back out the list_join change.

[Steve Baker (steve-stevebaker)]

Yes, going back to heat_template_version: 2013-05-23 and doing a straight replace of list_join to Fn::Join should work with older heats; I'll propose the change.

As an aside, how soon can tripleo use a new feature from heat?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113148

[Robert Collins (lifeless)]

We discuss backwards compatibility in the proposed backwards compat spec; this is related to that but a nuance we didn't cover. I think saying 'a release' would make sense - we can't require folk to upgrade to unreleased code; and we have to let folk upgrade. It's ok to be complex to upgrade - but it has to be possible.

[Robert Collins (lifeless)]

Further news - it turns out that non-HOT -> HOT stack-update appears to be broken in heat - see bug 1354962 - so I think we're going to have to revert this, otherwise we're breaking anyone who has deployed already.

[Robert Collins (lifeless)]

I9b91e5dbf18810a11389b96232461ae44849f6ec reverts all the HOT stuff.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/113148
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8a99e7d461f211f43751d5c72c8dbc5d1ae05ead
Submitter: Jenkins
Branch: master

commit 8a99e7d461f211f43751d5c72c8dbc5d1ae05ead
Author: Steve Baker <email address hidden>
Date: Mon Aug 11 09:18:01 2014 +1200

    Switch to heat_template_version: 2013-05-23

    To support underclouds and seeds running older than the very
    latest heat.

    2013-05-23 lacks function list_join, so this change reverts to
    using the equivalent function Fn::Join.

    Change-Id: I039f57ab39c1fcfc319a7a34265ba4fabf4ccd08
    Closes-Bug: #1354305