MySQL init script does not exit 1 upon a failed restart

[Julia Kreger]

While investigating https://bugs.launchpad.net/tripleo/+bug/1336915, We discovered that the script that is put in place for /etc/init.d/mysql does not return the error if the startup in the restart sequence fails. This is problematic as it means other tools that expect the restart call to return an error code if the restart failed, then believe that the service restarted successfully.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104569

[Julia Kreger (juliaashleykreger)]

Bug was reported to Percona, and it will be fixed in 5.5.38-25.11. https://bugs.launchpad.net/percona-xtradb-cluster/+bug/1339894

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104569
Committed: https://git.openstack.org/cgit/openstack/tripleo-image-elements/commit/?id=c0e211190d4b98286d831499e22b8b17a7158810
Submitter: Jenkins
Branch: master

commit c0e211190d4b98286d831499e22b8b17a7158810
Author: Julia Kreger <email address hidden>
Date: Thu Jul 3 10:29:02 2014 -0400

    Add detection of mysql restart failure

    The present script that is put in place to handle restarts of mysql,
    returns an exit code of 0 when a restart has failed as the return
    code from start is not captured inside the restart sequence.

    This change updates the logic in the script to detect the restart
    failure and exit the script with an exit code of 1. If the logic
    is already found, the script prints a warning.

    Filed with Percona:
    https://bugs.launchpad.net/percona-xtradb-cluster/+bug/1339894

    Change-Id: Ifdbaa11010cf19ab53c5d2fe4bbec186e58fe6dc
    Closes-Bug: 1337344