devtest_testenv.sh creates emtpy nodes array if the nodes are already defined in libvirt

Bug #1294083 reported by Matthew Gilliard on 2014-03-18
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Unassigned

Bug Description

The call to create-nodes has a loop to create nodes and add them to $TE_DATAFILE.nodes, but if they already exist (according to virsh list --all) then *both* steps are skipped. This means that the nodes' details are not added to the nodes array in the json file. So, running devtest_testenv.sh twice in a row results in an unusable $TE_DATAFILE.

It would be best to at least WARN that this is happenning, or even to pull the relevant information out of `virsh dumpxml baremetal_x`

James Polley (tchaypo) on 2014-03-19
Changed in tripleo:
status: New → Triaged
importance: Undecided → High
description: updated
James Polley (tchaypo) wrote :

I've just created https://review.openstack.org/#/c/90854/ which adds a more explicit warning about this to devtest.sh (and thus to devtest.html).

I've listed it as closing this bug, but I'd appreciate your feedback on whether you think that warning is sufficient.

Reviewed: https://review.openstack.org/90854
Committed: https://git.openstack.org/cgit/openstack/tripleo-incubator/commit/?id=4dea278b338d2221d912b36991d635c27a5cb9d6
Submitter: Jenkins
Branch: master

commit 4dea278b338d2221d912b36991d635c27a5cb9d6
Author: James Polley <email address hidden>
Date: Tue Apr 29 09:55:17 2014 +1000

    Make the admonition to only run _testenv once more explicit.

    Many people, on their second time running through the devtest_*.sh
    scripts following the instructions in devtest.html, seem to
    misunderstand the instructions about only running _testenv.sh once.

    To try to make this clearer, I've modified the language a little and put
    it into a "warning" box.

    Change-Id: I4fe24bb944d95fa348cb90702beffe4811c8e497
    Closes-bug: 1294083

Changed in tripleo:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers