getopt disorder output induce unrecognized arch

[Kui Shi]

For the file "tripleo-incubator/scripts/boot-seed-vm", there is a commit which add "i" option:

commit 444c63128d0354c97d66a3bb5b8e23ea39633bbb
    Add image already exists option to boot-seed-vm

The following change will disorder the getopt output:

-TEMP=`getopt -o hcna:o:s:b:e: -l use-existing-vm -n $SCRIPT_NAME -- "$@"`
+TEMP=`getopt -o hcnai:o:s:b:e: -l use-existing-vm -n $SCRIPT_NAME -- "$@"`

Here is error debug message:

++ getopt -o hcnai:o:s:b:e: -l use-existing-vm -n boot-seed-vm -- -a i386 ubuntu neutron-dhcp-agent
+ TEMP=' -a -- '\''i386'\'' '\''ubuntu'\'' '\''neutron-dhcp-agent'\'''
+ '[' 0 '!=' 0 ']'
+ eval set -- ' -a -- '\''i386'\'' '\''ubuntu'\'' '\''neutron-dhcp-agent'\'''
++ set -- -a -- i386 ubuntu neutron-dhcp-agent
+ true
+ case "$1" in
+ export ARCH=--
+ ARCH=--
+ shift 2
+ true
+ case "$1" in
+ echo 'Error: unsupported option i386.'
Error: unsupported option i386.

Here is a workaround for this:

@@ -61,7 +62,7 @@ function show_options () {
     exit 0
 }

-TEMP=`getopt -o hcnai:o:s:b:e: -l use-existing-vm -n $SCRIPT_NAME -- "$@"`
+TEMP=`getopt -o ihcna:o:s:b:e: -l use-existing-vm -n $SCRIPT_NAME -- "$@"`
 if [ $? != 0 ] ; then echo "Terminating..." >&2 ; exit 1 ; fi

 # Note the quotes around `$TEMP': they are essential!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/61271

[Roman Podoliaka (rpodolyaka)]

Fixed by https://review.openstack.org/#/c/61130