Fn::Select no longer accepts integer selector values

[Roman Podoliaka]

Change https://review.openstack.org/#/c/54063/ makes Fn::Select accept only string selector values. At the same time, our doc states, that the selector can be either of type string or of type integer (http://docs.openstack.org/developer/heat/template_guide/functions.html#fn-select)

If this is considered to be the correct behavior, we must update Heat docs and fix templates we are using in TripleO devtest story.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/54321

[Roman Podoliaka (rpodolyaka)]

Alternative fix to tripleo-heat-templates is here https://review.openstack.org/#/c/54322/

[Steven Hardy (shardy)]

https://review.openstack.org/#/c/54063/ should not have changed this behavior IMO, so this seems to be a regression which we missed at the review :(

[Clint Byrum (clint-fewbar)]

Agreed Steven. Marking Critical, this will break a lot of templates.

Let's make sure we follow up with some tempest tests.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54321
Committed: http://github.com/openstack/heat/commit/11ac4dd3f899dc0f28d356bad89ec559e9d1e81f
Submitter: Jenkins
Branch: master

commit 11ac4dd3f899dc0f28d356bad89ec559e9d1e81f
Author: Roman Podoliaka <email address hidden>
Date: Tue Oct 29 14:18:04 2013 +0200

    Make Fn::Select accept an integer selector again

    Closes-Bug: #1245863

    Change-Id: I364da88f1c581b406d51e1b584778c7dd4e2564f