Validations catalogue test fails on undercloud-tokenflush validation with failed template lookup

[Jiri Podivin]

Validation was recently added into catalogue test after it was demonstrated as functional on 17.0 deployment. Unfortunately it seems to be unstable, as it has failed during the recent test project run.

Trace:
------
     {
            "Duration": "0:00:00.723",
            "Host_Group": "undercloud",
            "Reasons": "undercloud: Failed to retrieve hiera data for keystone::token_\nprovider",
            "Status": "FAILED",
            "Status_by_Host": "undercloud,FAILED",
            "UUID": "d34fb4d5-0268-4e33-8c6b-0061d7f1b33a",
            "Unreachable_Hosts": "",
            "Validations": "undercloud-tokenflush"
        },

Logs:
-----
https://logserver.rdoproject.org/91/43591/16/check/periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-component-master-validation/1cac769/logs

[Jiri Podivin (jpodivin)]

Proposed fix: https://review.opendev.org/c/openstack/validations-common/+/862481

[Jiri Podivin (jpodivin)]

Tokens sought were droped from templates[0] in the process of uuid token provider removal.

This validation is therefore broken and should be removed as soon as possible, from master and wallaby.

[0]https://review.opendev.org/c/openstack/tripleo-heat-templates/+/683750

[Takashi Kajinami (kajinamit)]

The current implementation of the undercloud-tolenflush validation tries to read puppet hieradata from ansible_facts. This is completely wrong and never works. We probably should read keystone.conf instead.
 https://review.opendev.org/c/openstack/tripleo-validations/+/710065

Also, token flush job was already removed, before stable/train release, and TripleO supports only fernet token since then. Probably we should remove the validation completely.
 https://review.opendev.org/c/openstack/tripleo-heat-templates/+/683750

Note that we later re-introduced keystone_cron container to purge expired/deleted trusts. We might want to add a validation for that, though that would be less prioritized.
 https://review.opendev.org/c/openstack/tripleo-heat-templates/+/739383

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/862495

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/validations-common/+/862481
Committed: https://opendev.org/openstack/validations-common/commit/69033b04a862e77f6ed71f586c1eeba6c7e8bae4
Submitter: "Zuul (22348)"
Branch: master

commit 69033b04a862e77f6ed71f586c1eeba6c7e8bae4
Author: Jiri Podivin <email address hidden>
Date: Mon Oct 24 13:13:51 2022 +0200

    Disabling undercloud-tokenflush in catalogue tests

    Recently enabled undercloud-tokenflush validation appears unstable.
    It will be placed in the skip list until the issue is resolved.

    Related-Bug: #1994029

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: Idcd13dd967562af9eb91720a809a6148e810110d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/862495
Committed: https://opendev.org/openstack/tripleo-validations/commit/f48ff324577d43c4564e841ddc0310802af027b3
Submitter: "Zuul (22348)"
Branch: master

commit f48ff324577d43c4564e841ddc0310802af027b3
Author: Jiri Podivin <email address hidden>
Date: Mon Oct 24 16:21:36 2022 +0200

    Removing undercloud-tokenflush validation and related role

    The validation has been removed from the tripleo-validations package
    as the token management changes made it obsolete.[0]

    Role, molecule tests, derived CI job and documentation were removed with the validation itself.

    [0] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/683750

    Closes-Bug: #1994029

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I6c4bdff5e253bb054231dae2c3a280322cb18b9f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/864558

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/864560

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/864560
Committed: https://opendev.org/openstack/tripleo-validations/commit/7641a508e8e87e999c11b1df54ba8022e0d251b8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7641a508e8e87e999c11b1df54ba8022e0d251b8
Author: Jiri Podivin <email address hidden>
Date: Mon Oct 24 16:21:36 2022 +0200

    Removing undercloud-tokenflush validation and related role

    The validation has been removed from the tripleo-validations package
    as the token management changes made it obsolete.[0]

    Role, molecule tests, derived CI job and documentation were removed with the validation itself.

    [0] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/683750

    Closes-Bug: #1994029

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I6c4bdff5e253bb054231dae2c3a280322cb18b9f
    (cherry picked from commit f48ff324577d43c4564e841ddc0310802af027b3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/864558
Committed: https://opendev.org/openstack/tripleo-validations/commit/c1f0d3932a115acf2cbe0785b5c4f7680c14688f
Submitter: "Zuul (22348)"
Branch: stable/zed

commit c1f0d3932a115acf2cbe0785b5c4f7680c14688f
Author: Jiri Podivin <email address hidden>
Date: Mon Oct 24 16:21:36 2022 +0200

    Removing undercloud-tokenflush validation and related role

    The validation has been removed from the tripleo-validations package
    as the token management changes made it obsolete.[0]

    Role, molecule tests, derived CI job and documentation were removed with the validation itself.

    [0] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/683750

    Closes-Bug: #1994029

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I6c4bdff5e253bb054231dae2c3a280322cb18b9f
    (cherry picked from commit f48ff324577d43c4564e841ddc0310802af027b3)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/validations-common/+/873356

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/validations-common/+/873356
Committed: https://opendev.org/openstack/validations-common/commit/ef9ccda96e65c07cce5be51f9fea71431f6856af
Submitter: "Zuul (22348)"
Branch: master

commit ef9ccda96e65c07cce5be51f9fea71431f6856af
Author: Jiri Podivin <email address hidden>
Date: Fri Feb 10 09:57:44 2023 +0100

    Resolving catalog test entries for image-serve and undercloud-tokenflush

    The image-serve validation was fixed by I90171b424f0678001c2ca53a1fee819993fff6f5
    The undercloud-tokenflush validation was removed completely in
    I6c4bdff5e253bb054231dae2c3a280322cb18b9f as it is not relevant for more recent releases.

    Related-bug: #1959864
    Related-bug: #1994029

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I23431b685c00730affe69fb6ebcbb3223b31057a