tls_everywhere validation fails on ansible_fqdn

[Michele Baldessari]

Seen via https://bugzilla.redhat.com/show_bug.cgi?id=1953124

021-04-22 22:08:36,708 p=36100 u=mistral n=ansible | fatal: [undercloud]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ tls_everywhere_undercloud_fqdn | default(ansible_fqdn) }}: 'ansible_fqdn' is undefined\n\nThe error appears to be in '/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml': line 59, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n - name: kinit as the host entity\n ^ here\n"}
2021-04-22 22:08:36,718 p=36100 u=mistral n=ansible | TASK [tls_everywhere : clean up the keytab] ************************************
2021-04-22 22:08:36,718 p=36100 u=mistral n=ansible | Thursday 22 April 2021 22:08:36 +0000 (0:00:00.072) 0:06:06.576 ********
2021-04-22 22:08:37,239 p=36100 u=mistral n=ansible | changed: [undercloud] => {"changed": true, "cmd": ["kdestroy", "-A"], "delta": "0:00:00.032105", "end": "2021-04-22 22:08:37.136796", "rc": 0, "start": "2021-04-22 22:08:37.104691", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
2021-04-22 22:08:37,250 p=36100 u=mistral n=ansible | TASK [tls_everywhere : set output for molecule testing] ************************
2021-04-22 22:08:37,250 p=36100 u=mistral n=ansible | Thursday 22 April 2021 22:08:37 +0000 (0:00:00.531) 0:06:07.108 ********
2021-04-22 22:08:37,311 p=36100 u=mistral n=ansible | fatal: [undercloud]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'stdout'\n\nThe error appears to be in '/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml': line 101, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n - name: set output for molecule testing\n ^ here\n"}

Likely another fallout due to the optimizations in:
https://opendev.org/openstack/tripleo-heat-templates/commit/4e79336d69e6b7fa4b026922bac7953bafeee96d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/787835

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/787988

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/787989

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/787990

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/787835
Committed: https://opendev.org/openstack/tripleo-validations/commit/b63d45a2c6d108c3ad62b098a07af72736650755
Submitter: "Zuul (22348)"
Branch: master

commit b63d45a2c6d108c3ad62b098a07af72736650755
Author: Michele Baldessari <email address hidden>
Date: Sat Apr 24 11:12:45 2021 +0200

    Make tls_everywhere validations compatible with ansible_facts

    Via [1] we cannot rely on ansible_* vars anymore. So let's switch to
    ansible_facts. This should fix the following error:

      2021-04-22 22:08:36,708 p=36100 u=mistral n=ansible | fatal:
      [undercloud]: FAILED! => {"msg": "The task includes an option with an
      undefined variable. The error was: {{ tls_everywhere_undercloud_fqdn |
      default(ansible_fqdn) }}: 'ansible_fqdn' is undefined\n\nThe error
      appears to be in
      '/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml':
      line 59, column 7, but may\nbe elsewhere in the file depending on the
      exact syntax problem.\n\nThe offending line appears to be:\n\n\n -
      name: kinit as the host entity\n ^ here\n"}

    Closes-Bug: #1925999

    [1] https://opendev.org/openstack/tripleo-heat-templates/commit/4e79336d69e6b7fa4b026922bac7953bafeee96d

    Change-Id: If23c41d343678dcbbd0b4aae10ca6281a33e385f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/787988
Committed: https://opendev.org/openstack/tripleo-validations/commit/7382be2d324607cbb4970be30ccf5a47a42a8f0c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 7382be2d324607cbb4970be30ccf5a47a42a8f0c
Author: Michele Baldessari <email address hidden>
Date: Sat Apr 24 11:12:45 2021 +0200

    Make tls_everywhere validations compatible with ansible_facts

    Via [1] we cannot rely on ansible_* vars anymore. So let's switch to
    ansible_facts. This should fix the following error:

      2021-04-22 22:08:36,708 p=36100 u=mistral n=ansible | fatal:
      [undercloud]: FAILED! => {"msg": "The task includes an option with an
      undefined variable. The error was: {{ tls_everywhere_undercloud_fqdn |
      default(ansible_fqdn) }}: 'ansible_fqdn' is undefined\n\nThe error
      appears to be in
      '/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml':
      line 59, column 7, but may\nbe elsewhere in the file depending on the
      exact syntax problem.\n\nThe offending line appears to be:\n\n\n -
      name: kinit as the host entity\n ^ here\n"}

    Closes-Bug: #1925999

    [1] https://opendev.org/openstack/tripleo-heat-templates/commit/4e79336d69e6b7fa4b026922bac7953bafeee96d

    Change-Id: If23c41d343678dcbbd0b4aae10ca6281a33e385f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/787989
Committed: https://opendev.org/openstack/tripleo-validations/commit/62b33cb30cee932d6a0db90fe0f2adfbc4407499
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 62b33cb30cee932d6a0db90fe0f2adfbc4407499
Author: Michele Baldessari <email address hidden>
Date: Sat Apr 24 11:12:45 2021 +0200

    Make tls_everywhere validations compatible with ansible_facts

    Via [1] we cannot rely on ansible_* vars anymore. So let's switch to
    ansible_facts. This should fix the following error:

      2021-04-22 22:08:36,708 p=36100 u=mistral n=ansible | fatal:
      [undercloud]: FAILED! => {"msg": "The task includes an option with an
      undefined variable. The error was: {{ tls_everywhere_undercloud_fqdn |
      default(ansible_fqdn) }}: 'ansible_fqdn' is undefined\n\nThe error
      appears to be in
      '/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml':
      line 59, column 7, but may\nbe elsewhere in the file depending on the
      exact syntax problem.\n\nThe offending line appears to be:\n\n\n -
      name: kinit as the host entity\n ^ here\n"}

    Closes-Bug: #1925999

    [1] https://opendev.org/openstack/tripleo-heat-templates/commit/4e79336d69e6b7fa4b026922bac7953bafeee96d

    Change-Id: If23c41d343678dcbbd0b4aae10ca6281a33e385f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/787990
Committed: https://opendev.org/openstack/tripleo-validations/commit/6ee98fbfba8461e770ef2edf5d144341483c5371
Submitter: "Zuul (22348)"
Branch: stable/train

commit 6ee98fbfba8461e770ef2edf5d144341483c5371
Author: Michele Baldessari <email address hidden>
Date: Sat Apr 24 11:12:45 2021 +0200

    Make tls_everywhere validations compatible with ansible_facts

    Via [1] we cannot rely on ansible_* vars anymore. So let's switch to
    ansible_facts. This should fix the following error:

      2021-04-22 22:08:36,708 p=36100 u=mistral n=ansible | fatal:
      [undercloud]: FAILED! => {"msg": "The task includes an option with an
      undefined variable. The error was: {{ tls_everywhere_undercloud_fqdn |
      default(ansible_fqdn) }}: 'ansible_fqdn' is undefined\n\nThe error
      appears to be in
      '/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml':
      line 59, column 7, but may\nbe elsewhere in the file depending on the
      exact syntax problem.\n\nThe offending line appears to be:\n\n\n -
      name: kinit as the host entity\n ^ here\n"}

    Closes-Bug: #1925999

    [1] https://opendev.org/openstack/tripleo-heat-templates/commit/4e79336d69e6b7fa4b026922bac7953bafeee96d

    Change-Id: If23c41d343678dcbbd0b4aae10ca6281a33e385f

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 14.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 13.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 11.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 12.3.5 release.