tripleo-ansible-inventory Error creating static inventory 'Undercloud'

[Michele Baldessari]

Starting today (this worked a couple of days ago) the inventory generation is broken:
$ tripleo-ansible-inventory --static-yaml-inventory /home/stack/inv.yaml
Error creating static inventory: 'Undercloud'

Maybe related to the fix for https://bugs.launchpad.net/tripleo/+bug/1913551 ?

(undercloud) [stack@undercloud-0 ~]$ rpm -qa |grep -e tripleo-heat -e tripleoclient -e tripleo-common
openstack-tripleo-common-containers-14.0.1-0.20210201094933.be7b231.el8.noarch
python3-tripleoclient-15.0.1-0.20210130164901.0c669f6.el8.noarch
openstack-tripleo-heat-templates-14.0.1-0.20210131084401.787b765.el8.noarch
openstack-tripleo-common-14.0.1-0.20210201094933.be7b231.el8.noarch
python3-tripleo-common-14.0.1-0.20210201094933.be7b231.el8.noarch

[Michele Baldessari (michele)]

(undercloud) [stack@undercloud-0 ~]$ tripleo-ansible-inventory --debug --static-yaml-inventory /home/stack/inv.yaml
Error creating static inventory: 'Undercloud'
Traceback (most recent call last):
  File "/usr/bin/tripleo-ansible-inventory", line 218, in main
    inventory.write_static_inventory(configs.static_yaml_inventory)
  File "/usr/lib/python3.6/site-packages/tripleo_common/inventories.py", line 125, in write_static_inventory
    inventory = self._merge(dynamic=False)
  File "/usr/lib/python3.6/site-packages/tripleo_common/inventories.py", line 111, in _merge
    inventory['Undercloud']['vars']['plans'].sort()
KeyError: 'Undercloud'

[Michele Baldessari (michele)]

Seems that this is due to Idf4269a2ae5ce9863e1eda2f824e7a9fc93847d2 (Generate inventory without any overcloud). In fact passing "--stack overcloud" to it fixes it for me. I think if nothing else we should print a proper error message and/or restore the previous default behaviour of this working without having to specify the stack?

[Daniel Bengtsson (damani42)]

We have the same error here[1], we will try the workaround to see if that works.

[1] https://review.opendev.org/c/openstack/tripleo-upgrade/+/773181

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Pinging Mathieu about it.

[mathieu bultel (mat-bultel)]

Fix proposed:
https://review.opendev.org/c/openstack/tripleo-validations/+/774781

[Michele Baldessari (michele)]

Reopening as this has not been fixed.

I do have the patch mentioned in comment 5

(undercloud) [stack@undercloud-0 ~]$ grep "auth_variables = {}" /usr/bin/tripleo-ansible-inventory |wc -l
1

(undercloud) [stack@undercloud-0 ~]$ rpm -qf `which /usr/bin/tripleo-ansible-inventory`
openstack-tripleo-validations-14.0.1-0.20210323051419.c876cbb.el8.noarch

But it still breaks:
(undercloud) [stack@undercloud-0 ~]$ tripleo-ansible-inventory --static-yaml-inventory inv.yml
WARNING:tripleo_common.inventory:Stack not found: None. No data found in neither neutron or heat. Only the undercloud will be added to the inventory.

Specifying the stack works:
(undercloud) [stack@undercloud-0 ~]$ tripleo-ansible-inventory --stack overcloud --static-yaml-inventory inv.yml
(undercloud) [stack@undercloud-0 ~]$

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/786565

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/786566

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/786568

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/786565
Committed: https://opendev.org/openstack/tripleo-validations/commit/065e13b6f4f4f1a2c7da213af8d11468e760e282
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 065e13b6f4f4f1a2c7da213af8d11468e760e282
Author: Mathieu Bultel <email address hidden>
Date: Wed Feb 10 09:53:44 2021 +0100

    Fix set by merging two list without duplicate

    The previous statement result to an empty list, this
    fix merge the two list and avoid duplicate

    Declare auth_variables dictionary to avoid
    reference before assignment issues

    Change-Id: Ie28357d692f604c647d0f252a932242024e84f6e
    Closes-Bug: #1914084
    (cherry picked from commit 6de73491d697ca92c8b8b7fcc9c445fe6f9f5d5d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/786568
Committed: https://opendev.org/openstack/tripleo-validations/commit/31577df1e54694cc00c1e086aeefb5c5eeb4f7e8
Submitter: "Zuul (22348)"
Branch: stable/train

commit 31577df1e54694cc00c1e086aeefb5c5eeb4f7e8
Author: Mathieu Bultel <email address hidden>
Date: Wed Feb 10 09:53:44 2021 +0100

    Fix set by merging two list without duplicate

    The previous statement result to an empty list, this
    fix merge the two list and avoid duplicate

    Declare auth_variables dictionary to avoid
    reference before assignment issues

    Change-Id: Ie28357d692f604c647d0f252a932242024e84f6e
    Closes-Bug: #1914084
    (cherry picked from commit 6de73491d697ca92c8b8b7fcc9c445fe6f9f5d5d)
    (cherry picked from commit 065e13b6f4f4f1a2c7da213af8d11468e760e282)
    (cherry picked from commit 9b2d173debe88709daf613353ed6191f9a45758a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/786566
Committed: https://opendev.org/openstack/tripleo-validations/commit/9b2d173debe88709daf613353ed6191f9a45758a
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 9b2d173debe88709daf613353ed6191f9a45758a
Author: Mathieu Bultel <email address hidden>
Date: Wed Feb 10 09:53:44 2021 +0100

    Fix set by merging two list without duplicate

    The previous statement result to an empty list, this
    fix merge the two list and avoid duplicate

    Declare auth_variables dictionary to avoid
    reference before assignment issues

    Change-Id: Ie28357d692f604c647d0f252a932242024e84f6e
    Closes-Bug: #1914084
    (cherry picked from commit 6de73491d697ca92c8b8b7fcc9c445fe6f9f5d5d)
    (cherry picked from commit 065e13b6f4f4f1a2c7da213af8d11468e760e282)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 14.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 13.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 11.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 12.3.5 release.