mysql-open-files-limit is broken because container_cli fact is missing

Bug #1901299 reported by Alexey Stupnikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Alexey Stupnikov

Bug Description

mysql-open-files-limit validation fails because of the following error:

{
    "task": {
        "hosts": {
            "overcloud-controller-0": {
                "_ansible_no_log": false,
                "action": "set_fact",
                "failed": true,
                "msg": "The task includes an option with an undefined variable. The error was: 'ansible.vars.hostvars.HostVarsVars object' has no attribute 'container_cli'\n\nThe error appears to be in '/usr/share/openstack-tripleo-validations/roles/mysql_open_files_limit/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Set container_cli fact from the inventory\n ^ here\n"
            }
        },
        "name": "Set container_cli fact from the inventory",
        "status": "FAILED"
    }
}

It looks like the problem is caused by lack of container_cli definition.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (master)

Fix proposed to branch: master
Review: https://review.opendev.org/759563

Changed in tripleo:
assignee: nobody → Alexey Stupnikov (astupnikov)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.opendev.org/759563
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=a2f5c55edb0392b9c46cbf75fdb5bb757756fe5a
Submitter: Zuul
Branch: master

commit a2f5c55edb0392b9c46cbf75fdb5bb757756fe5a
Author: Alexey Stupnikov <email address hidden>
Date: Sat Oct 24 12:40:45 2020 +0200

    Optimize container_cli usage by mysql-open-files-limit validation

    mysql-open-files-limit could fail because Ansible fails to obtain
    container_cli definition from inventory.

    There are multiple playbooks that use container_cli to run
    various commands. All playbooks but mysql-open-files-limit define
    container_cli in different way. This patch aligns container_cli
    definition and usage for mysql-open-files-limit validation with
    other validations.

    Change-Id: Ie957b9bb046e006be0e5cc56bd749a2fe67178e8
    Closes-Bug: #1901299
    Related: rhbz#1891202

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/759746

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/ussuri)

Reviewed: https://review.opendev.org/759746
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=bd800b9cbf34a85fe0c1ec145c1ddc28832a68d1
Submitter: Zuul
Branch: stable/ussuri

commit bd800b9cbf34a85fe0c1ec145c1ddc28832a68d1
Author: Alexey Stupnikov <email address hidden>
Date: Sat Oct 24 12:40:45 2020 +0200

    Optimize container_cli usage by mysql-open-files-limit validation

    mysql-open-files-limit could fail because Ansible fails to obtain
    container_cli definition from inventory.

    There are multiple playbooks that use container_cli to run
    various commands. All playbooks but mysql-open-files-limit define
    container_cli in different way. This patch aligns container_cli
    definition and usage for mysql-open-files-limit validation with
    other validations.

    Change-Id: Ie957b9bb046e006be0e5cc56bd749a2fe67178e8
    Closes-Bug: #1901299
    Related: rhbz#1891202
    (cherry picked from commit a2f5c55edb0392b9c46cbf75fdb5bb757756fe5a)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/760688

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/train)

Reviewed: https://review.opendev.org/760688
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=02f3308bf4b36e973ca3f67f23a5140ecb1f7097
Submitter: Zuul
Branch: stable/train

commit 02f3308bf4b36e973ca3f67f23a5140ecb1f7097
Author: Alexey Stupnikov <email address hidden>
Date: Sat Oct 24 12:40:45 2020 +0200

    Optimize container_cli usage by mysql-open-files-limit validation

    mysql-open-files-limit could fail because Ansible fails to obtain
    container_cli definition from inventory.

    There are multiple playbooks that use container_cli to run
    various commands. All playbooks but mysql-open-files-limit define
    container_cli in different way. This patch aligns container_cli
    definition and usage for mysql-open-files-limit validation with
    other validations.

    Change-Id: Ie957b9bb046e006be0e5cc56bd749a2fe67178e8
    Closes-Bug: #1901299
    Related: rhbz#1891202
    (cherry picked from commit a2f5c55edb0392b9c46cbf75fdb5bb757756fe5a)
    (cherry picked from commit bd800b9cbf34a85fe0c1ec145c1ddc28832a68d1)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 12.3.3

This issue was fixed in the openstack/tripleo-validations 12.3.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 11.4.0

This issue was fixed in the openstack/tripleo-validations 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.