nova-event-callback validation doesn't validate vif_plugging_timeout_check properly

[Alexey Stupnikov]

puppet-nova sets vif_plugging_timeout to 300 seconds by default. In tripleo validations vif_plugging_timeout_value_min is set to 300 seconds [1]

But appropriate check [2] seem to contain a typo: check "Check Nova configuration values" should fail if vif_plugging_timeout_value_min is greater than actual sets vif_plugging_timeout, but actual code tells it to fail if it is greater than or equal.

It looks like a minor bug.

[1]
https://github.com/openstack/tripleo-validations/blob/stable/train/playbooks/nova-event-callback.yaml#L24

[2]
https://github.com/openstack/tripleo-validations/blob/stable/train/roles/nova_event_callback/tasks/main.yml#L19

[Alexey Stupnikov (astupnikov)]

This bug was addressed in master: https://review.opendev.org/#/c/747463/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/759558

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/759558
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=bbc99b7aeebed97405dbe68dc04b1ef0b4024fec
Submitter: Zuul
Branch: stable/ussuri

commit bbc99b7aeebed97405dbe68dc04b1ef0b4024fec
Author: Artom Lifshitz <email address hidden>
Date: Fri Aug 21 14:40:00 2020 -0400

    Refactor vif plugging validations

    It makes no sense to lump vif_plugging_timeout and vif_plugging_fatal
    into the same tasks. One is a numeric value validated to be larger
    than a minimum, the other is a boolean value validated to be set to
    True. Split them into separate tasks, and clarify the failure error
    messages.

    Closes-Bug: #1901297
    Related: rhbz#1891197

    Change-Id: I7a28f6014c55293d018d5fbc3223a26a10550f1c
    (cherry picked from commit ee19a57bc58fc8cbfa6ec761fba383a1bfaa48b0)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/759745

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/759745
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=c8d92bc9c38922ff9d5cb419c67e40718c12e76c
Submitter: Zuul
Branch: stable/train

commit c8d92bc9c38922ff9d5cb419c67e40718c12e76c
Author: Artom Lifshitz <email address hidden>
Date: Fri Aug 21 14:40:00 2020 -0400

    Refactor vif plugging validations

    It makes no sense to lump vif_plugging_timeout and vif_plugging_fatal
    into the same tasks. One is a numeric value validated to be larger
    than a minimum, the other is a boolean value validated to be set to
    True. Split them into separate tasks, and clarify the failure error
    messages.

    Closes-Bug: #1901297
    Related: rhbz#1891197

    Change-Id: I7a28f6014c55293d018d5fbc3223a26a10550f1c
    (cherry picked from commit ee19a57bc58fc8cbfa6ec761fba383a1bfaa48b0)
    (cherry picked from commit bbc99b7aeebed97405dbe68dc04b1ef0b4024fec)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 12.3.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 11.4.0 release.