tripleo-ansible-inventory doesn't output info for overcloud nodes anymore

Bug #1666662 reported by Martin André
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Martin André

Bug Description

Since novaclient 7.0.0, the tripleo-ansible-inventory silently ignores a novaclient error and skips all overcloud nodes in its output.

Here is the novaclient error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/novaclient/v2/servers.py", line 861, in list
    "servers")
  File "/usr/lib/python2.7/site-packages/novaclient/base.py", line 254, in _list
    resp, body = self.api.client.get(url)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/adapter.py", line 217, in get
    return self.request(url, 'GET', **kwargs)
  File "/usr/lib/python2.7/site-packages/novaclient/client.py", line 74, in request
    **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/adapter.py", line 374, in request
    resp = super(LegacyJsonAdapter, self).request(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/adapter.py", line 142, in request
    return self.session.request(url, method, **kwargs)
  File "/usr/lib/python2.7/site-packages/positional/__init__.py", line 101, in inner
    return wrapped(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/session.py", line 491, in request
    auth_headers = self.get_auth_headers(auth)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/session.py", line 818, in get_auth_headers
    return auth.get_headers(self, **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/plugin.py", line 90, in get_headers
    token = self.get_token(session)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/identity/base.py", line 90, in get_token
    return self.get_access(session).auth_token
  File "/usr/lib/python2.7/site-packages/keystoneauth1/identity/base.py", line 136, in get_access
    self.auth_ref = self.get_auth_ref(session)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/identity/generic/base.py", line 196, in get_auth_ref
    self._plugin = self._do_create_plugin(session)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/identity/generic/base.py", line 135, in _do_create_plugin
    authenticated=False)
  File "/usr/lib/python2.7/site-packages/positional/__init__.py", line 101, in inner
    return wrapped(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/identity/base.py", line 319, in get_discovery
    authenticated=authenticated)
  File "/usr/lib/python2.7/site-packages/positional/__init__.py", line 101, in inner
    return wrapped(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/discover.py", line 140, in __init__
    authenticated=authenticated)
  File "/usr/lib/python2.7/site-packages/positional/__init__.py", line 101, in inner
    return wrapped(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/discover.py", line 40, in get_version_data
    resp = session.get(url, headers=headers, authenticated=authenticated)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/session.py", line 758, in get
    return self.request(url, 'GET', **kwargs)
  File "/usr/lib/python2.7/site-packages/positional/__init__.py", line 101, in inner
    return wrapped(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/keystoneauth1/session.py", line 506, in request
    if not urllib.parse.urlparse(url).netloc:
  File "/usr/lib64/python2.7/urlparse.py", line 142, in urlparse
    tuple = urlsplit(url, scheme, allow_fragments)
  File "/usr/lib64/python2.7/urlparse.py", line 181, in urlsplit
    i = url.find(':')
AttributeError: 'NoneType' object has no attribute 'find'

Changed in tripleo:
status: New → Triaged
milestone: none → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (master)

Fix proposed to branch: master
Review: https://review.openstack.org/442193

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.openstack.org/442193
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=f6a8d3d9cd50a78c00e7323e9db56ab5ef878c28
Submitter: Jenkins
Branch: master

commit f6a8d3d9cd50a78c00e7323e9db56ab5ef878c28
Author: Martin André <email address hidden>
Date: Tue Feb 21 15:09:36 2017 -0500

    Migrate from keystoneclient to keystoneauth

    Since novaclient 7.0.0, the tripleo-ansible-inventory silently ignores
    a novaclient error and skips all overcloud nodes in its output.

    Switching to keystoneauth solves the issue in a clean fashion.

    Change-Id: I2019ceebda8bf6bf2e1f01bba9e1d5c143c8738d
    Closes-Bug: #1666662

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/453180

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/ocata)

Reviewed: https://review.openstack.org/453180
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=cafd51c1c6a8883e670249a75a49d927a1789ce5
Submitter: Jenkins
Branch: stable/ocata

commit cafd51c1c6a8883e670249a75a49d927a1789ce5
Author: Martin André <email address hidden>
Date: Tue Feb 21 15:09:36 2017 -0500

    Migrate from keystoneclient to keystoneauth

    Since novaclient 7.0.0, the tripleo-ansible-inventory silently ignores
    a novaclient error and skips all overcloud nodes in its output.

    Switching to keystoneauth solves the issue in a clean fashion.

    Change-Id: I2019ceebda8bf6bf2e1f01bba9e1d5c143c8738d
    Closes-Bug: #1666662
    (cherry picked from commit f6a8d3d9cd50a78c00e7323e9db56ab5ef878c28)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 7.0.0

This issue was fixed in the openstack/tripleo-validations 7.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 5.5.0

This issue was fixed in the openstack/tripleo-validations 5.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.