Validator has a TODO in its description, which shows up in the GUI

[Udi Kalifon]

The description of the validator "Check connectivity to various OpenStack services" has this TODO in it:

# TODO: this could also check for undercloud encpoints

It's very conspicuous in the GUI, where it shows up under the title of the validator and makes it look like this validator is still not fully implemented.

* Also note the typo in "encpoints"

[Udi Kalifon (ukalifon)]

The rest of the description of this validator is also incorrect. It says:

"This will attempt to connect to each service endpoint defined in your hosts file's controller_vip variable."

The validator gets the VIP from $(tripleo-ansible-inventory --list) which should come from $(heat output-show overcloud PublicVip). The validator is also currently checking horizon and keystone only.

[Julie Pichon (jpichon)]

https://github.com/openstack/tripleo-validations/blob/master/validations/openstack-endpoints.yaml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/404288

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/404288
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=875882a41c9523ac100e0ed0ddac993529d2ea36
Submitter: Jenkins
Branch: master

commit 875882a41c9523ac100e0ed0ddac993529d2ea36
Author: MikeG451 <email address hidden>
Date: Tue Nov 29 15:39:42 2016 +0000

    Remove TODO in Validation description, revise description

    Move TODO text so it will not appear in description and GUI.
    Revise description to better describe behavior of validation.

    Change-Id: I580e26dfb74c299340e1cba6a4c1aca10edf180a
    Closes-bug: #1643541

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 5.3.0 release.