tripleo

When tripleo_ui_config.js is used, %(tenant_id)s macro is not expanded

Bug #1649997 reported by Dan Trainor on 2016-12-14

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Julie Pichon	tripleo ocata-3 "ocata-3"

Bug Description

When using the tripleo_ui_config.js to tweak service endpoint specifications, the %(tenant_id)s macro is not expanded. Without this macro being expanded, one must manually configure for its value based on the output of 'openstack catalog show ...'.

When using the Keystone service catalog, other clients do expand the %(tenant_id)s macro. Other clients do not need a manual configuration the way that UI does in this scenario.

The UI should have a means of expanding this macro based on the information it receives from Keystone.

Tags:

Jason E. Rist (jason-rist) on 2016-12-14

Changed in tripleo:
status:	New → Triaged
status:	Triaged → Confirmed
importance:	Undecided → Critical
assignee:	nobody → Dan Trainor (dtrainor)
tags:	added: newton-backport-potential

Dan Trainor (dtrainor) on 2016-12-14

Changed in tripleo:
assignee:	Dan Trainor (dtrainor) → nobody

Emilien Macchi (emilienm) on 2016-12-14

Changed in tripleo:
milestone:	none → ocata-3
status:	Confirmed → Triaged

Revision history for this message

Julie Pichon (jpichon) wrote on 2016-12-15:

There is an easy workaround so, IMO this isn't "critical". The documentation usually indicates to set the full service URLs, including tenant id. When the URLs aren't overridden (i.e. only Keystone is set, which should be the case in environments where the undercloud is directly accessible), the URLs are picked up from Keystone correctly and there is no such issue. I do agree it'd be nice to fix in general though.

Changed in tripleo:
importance:	Critical → High

Julie Pichon (jpichon) on 2017-01-11

Changed in tripleo:
assignee:	nobody → Julie Pichon (jpichon)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-11: Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/419070

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-13: Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/419070
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=10d51ae5cfcbed2fb52e42e7c51558c8b545a1a9
Submitter: Jenkins
Branch: master

commit 10d51ae5cfcbed2fb52e42e7c51558c8b545a1a9
Author: Julie Pichon <email address hidden>
Date: Wed Jan 11 17:35:57 2017 +0000

Expand %(tenant_id)s macro in service URLs

    Without this, some actions such as tarball upload for plan creation
    fail, forcing the user to manually expand the macros in the config
    file.

Change-Id: Ie6dc01496c07c6423dd243c1a13b0c066caa0e3b
Closes-Bug: #1649997

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-16: Fix proposed to tripleo-ui (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/420594

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-24: Fix merged to tripleo-ui (stable/newton)

Reviewed: https://review.openstack.org/420594
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=c45508ffeefe8924c0799cfe3ccd7ed5a7fbd367
Submitter: Jenkins
Branch: stable/newton

commit c45508ffeefe8924c0799cfe3ccd7ed5a7fbd367
Author: Julie Pichon <email address hidden>
Date: Wed Jan 11 17:35:57 2017 +0000

Expand %(tenant_id)s macro in service URLs

    Without this, some actions such as tarball upload for plan creation
    fail, forcing the user to manually expand the macros in the config
    file.

    Change-Id: Ie6dc01496c07c6423dd243c1a13b0c066caa0e3b
    Closes-Bug: #1649997
    (cherry picked from commit 10d51ae5cfcbed2fb52e42e7c51558c8b545a1a9)