Updates/upgrades only work on deployed-server

[Jiří Stránský]

By fixing updates on deployed server (bug 1757090) i broke it on non-deployed-server. That solution would probably work fine in Rocky+ but for now we cannot depend on tripleo-admin user to exist in all environments. We either need to create it or provide --ssh-user customizability.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/557700

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/557747

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/558855

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/557747
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=17cd14114ffc8ca3e51fde550483aa0e21f19ffc
Submitter: Zuul
Branch: master

commit 17cd14114ffc8ca3e51fde550483aa0e21f19ffc
Author: Jiri Stransky <email address hidden>
Date: Thu Mar 29 18:05:21 2018 +0200

    Allow providing --ssh-user for update/upgrade run commands

    When config-download becomes our only way of deploying, we'll be able
    to assume that tripleo-admin user always exists. Until then it's not a
    given, so we need to allow using custom user names for running updates
    and upgrades playbooks. We default to heat-admin for now, as that's
    expected to work on majority of current production environments.

    Change-Id: I0df57002b2305c1e2504c9f7a7d0c326d8ffcaf7
    Closes-Bug: #1759845

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/558850
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=6415178b25559032d51fa8c6722c5cd99306bd32
Submitter: Zuul
Branch: master

commit 6415178b25559032d51fa8c6722c5cd99306bd32
Author: Jiri Stransky <email address hidden>
Date: Wed Apr 4 17:25:45 2018 +0200

    Support --ssh-user argument to upgrade/update run command

    To allow upgrading both Nova based and Deployed Server based
    environments, we introduced --ssh-user argument (until all envs have
    tripleo-admin user).

    Note: CLI for FFWD upgrade is being implemented, so a --ssh-user patch
    to tripleo-upgrade FFWD will have to follow later.

    Related-Bug: #1759845
    Depends-On: I0df57002b2305c1e2504c9f7a7d0c326d8ffcaf7
    Change-Id: Ib486a812aa9fd96bc753eda122cd05682d97b209

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/559311

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/559312

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/559311
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=1c1af2a38443a666ebe33877bdc2650513c84ea0
Submitter: Zuul
Branch: stable/queens

commit 1c1af2a38443a666ebe33877bdc2650513c84ea0
Author: Jiri Stransky <email address hidden>
Date: Thu Mar 29 18:05:21 2018 +0200

    Allow providing --ssh-user for update/upgrade run commands

    When config-download becomes our only way of deploying, we'll be able
    to assume that tripleo-admin user always exists. Until then it's not a
    given, so we need to allow using custom user names for running updates
    and upgrades playbooks. We default to heat-admin for now, as that's
    expected to work on majority of current production environments.

    Change-Id: I0df57002b2305c1e2504c9f7a7d0c326d8ffcaf7
    Closes-Bug: #1759845
    (cherry picked from commit 17cd14114ffc8ca3e51fde550483aa0e21f19ffc)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/558855
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=190c3b6941b88621f234bd7e63ba29b111274085
Submitter: Zuul
Branch: master

commit 190c3b6941b88621f234bd7e63ba29b111274085
Author: Jiri Stransky <email address hidden>
Date: Wed Apr 4 17:39:06 2018 +0200

    Make sure we keep using tripleo-admin as ssh user in CI

    First we switched the user to tripleo-admin [1] which made CI on
    updates job green, but broke Nova-based environments. We're now
    switching the default back to heat-admin [2] which will break updates
    job again, so we add support to tripleo-upgrade [3] to customize the
    user name and set it here to the value for CI (deployed server
    environments).

    Fear not, when we switch to --config-download as our only supported
    deployment method, tripleo-admin should become unconditionally present
    in all environments, and we'll be able to converge to a single method
    of logging into the overcloud nodes.

    [1] I1ec66886d6d61ccf528e5e27872cf68c7a603727
    [2] I0df57002b2305c1e2504c9f7a7d0c326d8ffcaf7
    [3] Ib486a812aa9fd96bc753eda122cd05682d97b209

    Co-Authored-By: Jose Luis Franco <email address hidden>
    Change-Id: I063d438fbeeded28134658aaefc6c8b7119aee43
    Related-Bug: #1759845
    Depends-On: I0df57002b2305c1e2504c9f7a7d0c326d8ffcaf7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/559312
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=42a0ba62b3955caf68d9bd3a8f907af46104c96e
Submitter: Zuul
Branch: stable/queens

commit 42a0ba62b3955caf68d9bd3a8f907af46104c96e
Author: Jiri Stransky <email address hidden>
Date: Wed Apr 4 17:25:45 2018 +0200

    Support --ssh-user argument to upgrade/update run command

    To allow upgrading both Nova based and Deployed Server based
    environments, we introduced --ssh-user argument (until all envs have
    tripleo-admin user).

    Note: CLI for FFWD upgrade is being implemented, so a --ssh-user patch
    to tripleo-upgrade FFWD will have to follow later.

    Related-Bug: #1759845
    Depends-On: I0df57002b2305c1e2504c9f7a7d0c326d8ffcaf7
    Change-Id: Ib486a812aa9fd96bc753eda122cd05682d97b209
    (cherry picked from commit 6415178b25559032d51fa8c6722c5cd99306bd32)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 9.2.1 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/557700
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines (https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html). If you wish to have this restored and cannot do so yourself, please reach out via #tripleo on freenode or the OpenStack Dev mailing list.