gate-tripleo-ci-centos-7-containers-multinode-upgrades-pike-nv fails - No such file or directory /home/jenkins/overcloud-prep-containers.sh

[Ronelle Landy]

gate-tripleo-ci-centos-7-containers-multinode-upgrades-pike-nv was tested with no-op change https://review.openstack.org/#/c/556629/. The gate test fails upgrade with:

20:37:38 TASK [tripleo-upgrade : download container images] *****************************
20:37:38 Monday 26 March 2018 20:37:38 +0000 (0:00:00.093) 0:05:01.009 **********
20:37:41 fatal: [undercloud]: FAILED! => {"changed": true, "cmd": "bash /home/jenkins/overcloud-prep-containers.sh", "delta": "0:00:00.007518", "end": "2018-03-26 20:37:41.047393", "failed": true, "msg": "non-zero return code", "rc": 127, "start": "2018-03-26 20:37:41.039875", "stderr": "bash: /home/jenkins/overcloud-prep-containers.sh: No such file or directory", "stderr_lines": ["bash: /home/jenkins/overcloud-prep-containers.sh: No such file or directory"], "stdout": "", "stdout_lines":

See full log here:

https://logs.rdoproject.org/29/556629/1/openstack-check/gate-tripleo-ci-centos-7-containers-multinode-upgrades-pike-nv/Z363923293f504b79b1542b5d2f525dc5/

See list of available files on the undercloud here:

https://logs.rdoproject.org/29/556629/1/openstack-check/gate-tripleo-ci-centos-7-containers-multinode-upgrades-pike-nv/Z363923293f504b79b1542b5d2f525dc5/undercloud/home/jenkins/

Here are the variable definitions and usages:

 - Feature set 011:
https://github.com/openstack/tripleo-quickstart/blob/master/config/general_config/featureset011.yml#L45 defines ... container_images_download_script: '{{ working_dir }}/overcloud-prep-containers.sh'

 - However, the playbook
https://github.com/openstack/tripleo-quickstart-extras/blob/master/playbooks/multinode-overcloud-upgrade-new.yml#L31 defines ... overcloud_prep_containers_script: "upgrade_overcloud_prep_containers.sh"

 - /home/jenkins/overcloud-prep-containers.sh is not created in the initial overcloud-prep-containers run (containerized_overcloud: false) - # we're upgrading from non-containers to containers, so first we deploy non-containerized overcloud

- When 'Prepare containers for Upgrade' runs 'overcloud-prep-containers : Create overcloud prep-containers script', the resulting script is called 'upgrade_overcloud_prep_containers.sh' as opposed to the default https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-prep-containers/defaults/main.yml#L5 overcloud-prep-containers.sh

and overcloud-prep-containers.sh is not found in the home dir but upgrade_overcloud_prep_containers.sh is.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/556860

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/556860
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=efbacd05f535713bac47cb67b595206127a47abb
Submitter: Zuul
Branch: master

commit efbacd05f535713bac47cb67b595206127a47abb
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue Mar 27 15:55:07 2018 +0200

    Update overcloud-prep-containers script name.

    After merging [0], the name set to the script
    used to prepare containers before the upgrade
    step hast changed. This patch sets the right
    name in the featureset, so O->P job doesn't
    fail.

    [0] - https://review.openstack.org/#/c/540473/

    Depends-On: I033ec0d0dd4fbf26b7231ca48d73f28c12e78b0f
    Change-Id: I8cc94500c317c49cb68567f79f65f0e12fcd75ea
    Closes-Bug: #1759060

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart 2.1.1 release.