Tripleo quickstart and tripleo-upgrade integration should be a role.

[Sofer Athlan-Guyot]

The glue code between tripleo-quickstart and tripleo-upgrade has been done directly in the playbook. This is not the right way, as we introduce tasks inside the playbook while it should only contain role.

We're merging it like this to move forward the tripleo-upgrade integration and gating. The creation of the role should follow quickly though.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

https://review.openstack.org/#/c/542311/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/542311
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=80ba11d9d644cc64134bb488b8d46eec7825b542
Submitter: Zuul
Branch: master

commit 80ba11d9d644cc64134bb488b8d46eec7825b542
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Feb 7 10:06:26 2018 +0100

    Upgrade UC and OC using tripleo-upgrade role.

    Link tripleo-upgrade [0] role into oooq multinode playbook:

     - Added a containers preparation step for upgrades
     - Call tripleo-upgrade role with the specific parameters set in the
       job featureset.

    [0] https://github.com/openstack/tripleo-upgrade

    This keeps backward compatibility.

    All the necessary bit for the docker switching repository
    configuration will come in a later patch. Here we just add the step.
    The first target of this role being O->P, this isn't yet needed as
    docker images are not upgrade in this scenario.

    We are introducing a tech-debt here. We have to refactor the set of
    tasks introduced in the playbook to a proper role inside oooq-extra.
    This should be done in a following refactor.

    Related-Bug: #1749740

    implements: blueprint tripleo-upgrade

    Co-Authored-By: Sofer Athlan-Guyot <email address hidden>

    Change-Id: I92a1d915441686453ef0b241e4ba151c03595074

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/553492

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/542201
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=84aecbb2a34313c33ecd618154add38b53b3f553
Submitter: Zuul
Branch: master

commit 84aecbb2a34313c33ecd618154add38b53b3f553
Author: Jiri Stransky <email address hidden>
Date: Thu Feb 8 15:04:03 2018 +0100

    Overcloud update CI with tripleo-upgrade role

    This adds update sub-playbook to the multinode playbook, it only gets
    executed if overcloud-update tag is set.

    Co-Authored-By: Jose Luis Franco <email address hidden>
    Related-Bug: #1749740
    Change-Id: I75a358dea33c8befef37aceddeb02e30599d3f7a

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/561903

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/561927

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/564222

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/564225

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jose Luis Franco (<email address hidden>) on branch: master
Review: https://review.openstack.org/561903
Reason: Not needed

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561927
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=a65a8418cb8cd6df3fd9796921866087b53ccdde
Submitter: Zuul
Branch: master

commit a65a8418cb8cd6df3fd9796921866087b53ccdde
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue Apr 17 14:36:21 2018 +0200

    Remove tasks from overcloud upgrade playbook.

    Remove the tasks being executed inside the playbook used
    for running overcloud upgrades. Most of these task are
    being handled somewhere else (import tripleo-upgrade [0],
    mainly) so we can simplify the playbook by importing the
    tripleo-upgrade role with the required parameters defined
    in each fs.

    [0] Icc84645a16aa53ca2cb974dbeb52e6474cd98aab

    Related-Bug: #1749740
    Change-Id: Iaf30244187d27909ab803175843056e0827d0b24

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564225
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=29fb179262d88b875572b69f9798da3d794e7325
Submitter: Zuul
Branch: master

commit 29fb179262d88b875572b69f9798da3d794e7325
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Apr 25 15:34:08 2018 +0200

    Get rid of tasks in overcloud updates playbook.

    This patch removes all the tasks being executed
    inside the playbook used for running overcloud
    updates. Most of these removed tasks are being
    handled somewhere else (import triploe-upgrade [0],
    mainly) so we can simplify the playbook by calling
    the tripleo-upgrade role with the required
    parameters defined in each fs.

    This patch also gets rid of container_registry_file,
    which is being moved into the job's fs in [1].

    [0] Icc84645a16aa53ca2cb974dbeb52e6474cd98aab
    [1] I27f13b164bb78619f8830b875ec9f04445ce1e26

    Change-Id: Iec42b574d697f3acfd668636e3dd11217a3ea25e
    Related-Bug: #1749740

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564222
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=012d69bcdc17a67490edfecaeb62f5d4284ed87f
Submitter: Zuul
Branch: master

commit 012d69bcdc17a67490edfecaeb62f5d4284ed87f
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Apr 25 15:46:12 2018 +0200

    Remove use_tripleo_upgrade and add var into fs037.

    As part of the upgrades/updates playbook refactor
    it has been removed the existence of a 'legacy'
    and 'new' upgrades playbook, which was being
    controlled by the 'use_tripleo_upgrade' variable
    Iaf30244187d27909ab803175843056e0827d0b24.

    Also, it's been moved the parameter container_registry_file
    from the overcloud update's playbook into its
    corresponding fs.

    Related-Bug: #1749740

    Depends-On: Iaf30244187d27909ab803175843056e0827d0b24
    Depends-On: Iec42b574d697f3acfd668636e3dd11217a3ea25e
    Change-Id: I27f13b164bb78619f8830b875ec9f04445ce1e26

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/553492
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines (https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html). If you wish to have this restored and cannot do so yourself, please reach out via #tripleo on freenode or the OpenStack Dev mailing list.

[Jose Luis Franco (jfrancoa)]

This launchpad got addressed already in https://review.openstack.org/#/c/564222/