[python-tripleoclient] overcloud deployment fails, but exits 0

[wes hayutin]

As seen in
https://ci.centos.org/artifacts/rdo/jenkins-tripleo-quickstart-promote-newton-cloudsig-testing-minimal-7/undercloud/home/stack/overcloud_deploy.log.gz

The overcloud deployment fails however for what ever reason heat does not post a "CREATE_FAILED" statement that would trigger oooq to further debug the failure.

This can be fixed by adjusting the regex that detects the failure [1]

[1] https://github.com/redhat-openstack/ansible-role-tripleo-overcloud/blob/master/tasks/overcloud-status.yml#L14

[John Trowbridge (trown)]

This was originally filed as a tripleo-quickstart bug, but we should not need regex magic to detect a deployment failure. Instead the `openstack overcloud deploy` command should exit with non-zero exit code if it was not successful.

[Adriano Petrich (apetrich)]

Is it still happening? I'm not able to reproduce it. If I change the overcloud-deploy script like this https://review.openstack.org/#/c/405614/2/roles/overcloud-deploy/templates/overcloud-deploy.sh.j2

2016-12-01 12:07:36Z [overcloud.ControllerNodesPostDeployment.ControllerArtifactsDeploy]: CREATE_FAILED CREATE aborted
2016-12-01 12:07:36Z [overcloud.ControllerNodesPostDeployment]: CREATE_FAILED Resource CREATE failed: Operation cancelled

 Stack overcloud CREATE_FAILED

Heat Stack create failed.
+ result=1
+ echo 1
1

[wes hayutin (weshayutin)]

OK.. thanks for checking that out.. If it is not recreating you can close this.
Thank you