Multiple tags on the same commit break PBR

Bug #1917327 reported by Javier Peña on 2021-03-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo-ipsec
Undecided
Marios Andreou

Bug Description

We have multiple tags on the latest commit 3e445d6add5d9aa144bdfca196a199eed6461bc4, namely:

- 9.3.1
- 10.0.0
- 11.0.0

This breaks installation and even simple "python setup.py --version" when using PBR, as described in [1][2]. It also breaks semantic versioning, since we should not change the major release if there are no code changes.

[1] - https://bugs.launchpad.net/pbr/+bug/1453996
[2] - https://bugs.launchpad.net/networking-calico/+bug/1849110

Revision history for this message
Marios Andreou (marios-b) wrote :

thanks for filing that jpena as just discussed on irc i can try and make new releases to fix it with the outstanding patches

14:05 < jpena> marios: a potential fix to move forward would be merging the .gitreview changes for ussuri and victoria, then generating a new tag for each (9.3.2 / 10.0.1)
14:08 < jpena> marios: https://review.opendev.org/q/project:openstack/tripleo-ipsec+status:open
14:08 < jpena> actually, there is no defaultbranch tag in master's .gitreview, so that would give us the fix we need for master

Changed in tripleo-ipsec:
assignee: nobody → Marios Andreou (marios-b)
status: New → Triaged
Revision history for this message
Herve Beraud (herveberaud) wrote :

Hello everyone,

From a release point of view this kind of problem is now under control.

Indeed we recently introduced new checks [1] to ensure to not falls in a similar scenario.

These checks are now merged.

Concerning the existing tags, those who are problematic, they have been generated before we adding these new checks. This is a side effect of the trailing project model. Indeed those projects are trailing projects and they have been forgotten from a release point of view during the previous trailing deadline of the two previous series (ussuri and victoria). We created new check/process to handle similar cases and ensure to never forget to branch trailing projects in during next series.

To get rid of the current issue I agree we could generate new tags based gitreview changes discussed in the previous comment.

This will lead us more or less to a patch similar to this one https://review.opendev.org/c/openstack/releases/+/776636/

Our check [1] is based on pbr so we can't fail again on this point.

Concerning semver this is another discussion... Lot of projects release major versions for each cycle without releasing unbackward compatible changes...

This is an historical story, I'm not even have all the pieces of the puzzle who leaded us to this choice.

I don't think we want to mix the both topics and I'm not even sure that we can move away from this tradition (starting a new series with major version) (in a normal context without tag issue like here).

I seen many time people complain about this point in the past, I think that here are pro and con.

Maybe this could be a topics to discuss about during the next series. For now I think that we are too much closer from the final deadline to revolution this kind of tradition.

Thoughts?

[1] https://review.opendev.org/c/openstack/releases/+/776206/
[2] https://review.opendev.org/c/openstack/releases/+/776496/

Revision history for this message
Marios Andreou (marios-b) wrote :

ack thanks for checking Herve. WRT the semver - we won't/don't need to fix anything here mainly because we aren't even using this repo any more and so it will most likely go EOL if nothing else changes. I agree it is bit of a mess here, if you check the tags https://github.com/openstack/tripleo-ipsec/tags 9 is rocky 9.1 stein 9.2 train and 9.3 ussuri but as i said i don't think anyone is interested in fixing it.

For tripleo repos more generally we try to follow semver with bumping major for a new stable/ release.

But we should not leave this in a broken state so I have just sent the changes in https://review.opendev.org/c/openstack/tripleo-ipsec/+/773676
https://review.opendev.org/c/openstack/tripleo-ipsec/+/773677 (ussuri) and https://review.opendev.org/c/openstack/tripleo-ipsec/+/770776
https://review.opendev.org/c/openstack/tripleo-ipsec/+/770777 (victoria) to the gate. Trying to decide what to do about master, could be update .gitreview as jpena suggested but not sure ... we just need some dummy commit.

Once those merge I'll propose a new release for each of victoria/ussuri/wallaby with the new commit IDs.

Revision history for this message
Marios Andreou (marios-b) wrote :
Revision history for this message
Marios Andreou (marios-b) wrote :
Revision history for this message
Marios Andreou (marios-b) wrote :
Changed in tripleo-ipsec:
status: Triaged → In Progress
Revision history for this message
Marios Andreou (marios-b) wrote :

still waiting for https://review.opendev.org/c/openstack/releases/+/778925 will follow up on that later

Revision history for this message
Marios Andreou (marios-b) wrote :

https://review.opendev.org/c/openstack/releases/+/778925 merged moving this fix released

thanks very much jpena & hberaud & elod for your help

Changed in tripleo-ipsec:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers