[tripleo-ha-utils] auth_url, tenant_name, record_only is specified with '-(dash)'

Bug #1839063 reported by Keigo Noha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Keigo Noha

Bug Description

Current ansible-playbook is written as
~~~
$ grep auth-url -r *
roles/instance-ha/tasks/apply.yml: shell: "pcs stonith create fence-nova fence_compute auth-url=$OS_AUTH_URL login=$OS_USERNAME passwd=$OS_PASSWORD tenant-name=$OS_TENANT_NAME domain={{ overcloud_domain }} record-only=1 {{ pcs_fence_compute_no_shared_storage_opts }} --force"
roles/instance-ha/tasks/apply.yml: shell: "pcs stonith create fence-nova fence_compute auth-url=$OS_AUTH_URL login=$OS_USERNAME passwd=$OS_PASSWORD tenant-name=$OS_TENANT_NAME domain={{ overcloud_domain }} record-only=1 {{ pcs_fence_compute_no_shared_storage_opts }} meta provides=unfencing --force
~~~

However fence_nova accepts, those 3 paramters auth-url, record-only and tenant-name as auth_url, record_only and tenant_name.

It should be replaced with correct option name.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ha-utils (master)

Fix proposed to branch: master
Review: https://review.opendev.org/674745

Changed in tripleo:
assignee: nobody → Keigo Noha (knoha)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ha-utils (master)

Reviewed: https://review.opendev.org/674745
Committed: https://git.openstack.org/cgit/openstack/tripleo-ha-utils/commit/?id=8bb060b864baa79d50d411683b4ad75c96de34b8
Submitter: Zuul
Branch: master

commit 8bb060b864baa79d50d411683b4ad75c96de34b8
Author: Keigo Noha <email address hidden>
Date: Tue Aug 6 16:34:02 2019 +0900

    Replace '-' with '_' in fence_compute options.

    auth-url, tenant-name and read-only are defined in fence_compute as
    auth_url, tenant_name and read_only. This commit replaces '-' with '_'
    in those 3 options.

    Closes-Bug: #1839063
    Change-Id: I509ee3f405ed5adfbbb0b678650303a6b4829fcd

Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.